linstor: use sparse/discard qemu-img convert on thin devices#11787
Merged
DaanHoogland merged 1 commit intoapache:4.19apache/cloudstack:4.19from Oct 6, 2025
LINBIT:linstor-4.19-use-sparse-convert-on-snapshot-revertLINBIT/cloudstack:linstor-4.19-use-sparse-convert-on-snapshot-revertCopy head branch name to clipboard
Merged
linstor: use sparse/discard qemu-img convert on thin devices#11787DaanHoogland merged 1 commit intoapache:4.19apache/cloudstack:4.19from LINBIT:linstor-4.19-use-sparse-convert-on-snapshot-revertLINBIT/cloudstack:linstor-4.19-use-sparse-convert-on-snapshot-revertCopy head branch name to clipboard
DaanHoogland merged 1 commit intoapache:4.19apache/cloudstack:4.19from
LINBIT:linstor-4.19-use-sparse-convert-on-snapshot-revertLINBIT/cloudstack:linstor-4.19-use-sparse-convert-on-snapshot-revertCopy head branch name to clipboard
Conversation
This reduces revert time and also makes the devices not thick allocated anymore.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11787 +/- ##
=========================================
Coverage 15.18% 15.18%
- Complexity 11370 11371 +1
=========================================
Files 5415 5415
Lines 476082 476089 +7
Branches 58129 58130 +1
=========================================
+ Hits 72288 72299 +11
+ Misses 395702 395698 -4
Partials 8092 8092
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Oct 17, 2025
sandeeplocharla
pushed a commit
to NetApp/cloudstack
that referenced
this pull request
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of always write zeroes to the drbd device, we enable now sparse/discard options for qemu-img convert,
if the Linstor device supports thin.
This reduces revert time and also makes the devices not thick allocated anymore.
Too ensure the devices only contains zeroes, we have to blkdiscard it before.
Fixes: #11765
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested local volume revert on a Linstor cluster.
This change should only affect Linstor primary storage, as no other code parts are touched.
How did you try to break this feature and the system with this change?