Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CKS: fix CKS creation on an existing Shared or Routed network#11735

Merged
vishesh92 merged 1 commit intoapache:4.20apache/cloudstack:4.20from
weizhouapache:4.22-cks-creation-shared-networkweizhouapache/cloudstack:4.22-cks-creation-shared-networkCopy head branch name to clipboard
Oct 3, 2025
Merged

CKS: fix CKS creation on an existing Shared or Routed network#11735
vishesh92 merged 1 commit intoapache:4.20apache/cloudstack:4.20from
weizhouapache:4.22-cks-creation-shared-networkweizhouapache/cloudstack:4.22-cks-creation-shared-networkCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Sep 26, 2025 •
edited
Loading

Description

This PR fixes a regression of #11528

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Sep 26, 2025

@blueorangutan package

@weizhouapache weizhouapache changed the title CKS: fix CKS creation on an existing Shared and Routed network CKS: fix CKS creation on an existing Shared or Routed network Sep 26, 2025
@blueorangutan
Copy link

blueorangutan commented Sep 26, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Sep 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.43%. Comparing base (36cfd76) to head (a954dbf).
⚠️ Report is 7 commits behind head on 4.20.

Files with missing lines Patch % Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #11735      +/-   ##
============================================
+ Coverage     16.17%   17.43%   +1.25%     
- Complexity    13296    15341    +2045     
============================================
  Files          5656     5892     +236     
  Lines        498219   526528   +28309     
  Branches      60451    64294    +3843     
============================================
+ Hits          80579    91785   +11206     
- Misses       408672   424388   +15716     
- Partials       8968    10355    +1387
Flag Coverage Δ
uitests 3.61% <ø> (-0.40%) ⬇️
unittests 18.48% <0.00%> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache added this to the 4.22.0 milestone Sep 26, 2025
@weizhouapache weizhouapache force-pushed the 4.22-cks-creation-shared-network branch from a90acfc to a954dbf Compare September 26, 2025 09:44
@weizhouapache weizhouapache changed the base branch from main to 4.20 September 26, 2025 09:44
@weizhouapache weizhouapache modified the milestones: 4.22.0, 4.20.2 Sep 26, 2025
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Sep 26, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Sep 26, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache marked this pull request as ready for review September 26, 2025 10:04
@blueorangutan
Copy link

blueorangutan commented Sep 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15182

@blueorangutan
Copy link

blueorangutan commented Sep 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15184

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Sep 26, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Sep 26, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Pearl1594
Pearl1594 approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

blueorangutan commented Sep 27, 2025

[SF] Trillian test result (tid-14450)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53352 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11735-t14450-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Oct 1, 2025

@Pearl1594
could you test this PR if you have time ?

@vishesh92
Copy link
Member

vishesh92 commented Oct 3, 2025

I am testing this PR.

@blueorangutan
Copy link

blueorangutan commented Oct 3, 2025

[SF] Trillian Build Failed (tid-14512)

@vishesh92
Copy link
Member

vishesh92 commented Oct 3, 2025

Before this change, the creation of CKS cluster in a shared network failed with the below error:
image

I also verified that issue didn't exist in 4.20.1. After this change, I am able to create CKS clusters in the shared network.

vishesh92
vishesh92 approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishesh92 vishesh92 merged commit e12813d into apache:4.20 Oct 3, 2025
27 of 28 checks passed
@DaanHoogland DaanHoogland deleted the 4.22-cks-creation-shared-network branch October 3, 2025 09:09
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
@weizhouapache @dhslove
CKS: fix CKS creation on an existing Shared and Routed network (apach…
9ba46ac 
…e#11735)
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025
@weizhouapache
CKS: fix CKS creation on an existing Shared and Routed network (apach…
23dbe3c 
…e#11735)
@weizhouapache weizhouapache mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:kubernetes Severity:Critical Critical bug

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @blueorangutan @vishesh92 @Pearl1594 @DaanHoogland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.