Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.42%. Comparing base (8eb6ddd) to head (63aaf2b).
⚠️ Report is 33 commits behind head on main.

@@             Coverage Diff              @@
##               main   #11726      +/-   ##
============================================
+ Coverage     17.39%   17.42%   +0.02%     
- Complexity    15285    15333      +48     
============================================
  Files          5889     5892       +3     
  Lines        526183   526521     +338     
  Branches      64242    64293      +51     
============================================
+ Hits          91542    91757     +215     
- Misses       424297   424410     +113     
- Partials      10344    10354      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?

@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?

Yes, @weizhouapache

@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?

Yes, @weizhouapache

good @abh1sar

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15171

@blueorangutan test

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-14441)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11726-t14441-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?

Yes. I used the template @abh1sar shared with me for this change. I verified the cloud init configuration changes as well in the sharedfs vm.

lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.

@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?

Yes. I used the template @abh1sar shared with me for this change. I verified the cloud init configuration changes as well in the sharedfs vm.

great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?

great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?

Yes. We will need to do that.

great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?

Yes. We will need to do that.

maybe after merge of #11654 ?