Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

api: use single quote instead of double quote in StatsResponse#11537

Merged
weizhouapache merged 1 commit intoapache:4.19apache/cloudstack:4.19from
weizhouapache:4.19-remove-double-quoteweizhouapache/cloudstack:4.19-remove-double-quoteCopy head branch name to clipboard
Aug 29, 2025
Merged

api: use single quote instead of double quote in StatsResponse#11537
weizhouapache merged 1 commit intoapache:4.19apache/cloudstack:4.19from
weizhouapache:4.19-remove-double-quoteweizhouapache/cloudstack:4.19-remove-double-quoteCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Aug 29, 2025

Description

This PR fixes simulator CI failures

Starting Advanced Zone DataCenter deployment
Traceback (most recent call last):
  File "/home/runner/work/cloudstack/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 28, in <module>
    from marvin import configGenerator
  File "/home/runner/.local/lib/python3.10/site-packages/marvin/configGenerator.py", line 21, in <module>
    from . import jsonHelper
  File "/home/runner/.local/lib/python3.10/site-packages/marvin/jsonHelper.py", line 20, in <module>
    from marvin.cloudstackAPI import *
  File "/home/runner/.local/lib/python3.10/site-packages/marvin/cloudstackAPI/listVirtualMachinesUsageHistory.py", line 95
    """"the time when the VM stats were collected. The format is "yyyy-MM-dd hh:mm:ss""""
                                                                                        ^
SyntaxError: unterminated string literal (detected at line 95)

related to #10152

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland
DaanHoogland approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (3109e00) to head (6b619f9).
⚠️ Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11537      +/-   ##
============================================
- Coverage     15.18%   15.18%   -0.01%     
+ Complexity    11374    11369       -5     
============================================
  Files          5415     5415              
  Lines        476073   476073              
  Branches      58125    58125              
============================================
- Hits          72299    72281      -18     
- Misses       395684   395705      +21     
+ Partials       8090     8087       -3
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member Author

weizhouapache commented Aug 29, 2025

@blueorangutan package

@weizhouapache weizhouapache marked this pull request as ready for review August 29, 2025 13:27
@blueorangutan
Copy link

blueorangutan commented Aug 29, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

vishesh92
vishesh92 approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blueorangutan
Copy link

blueorangutan commented Aug 29, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14774

@weizhouapache
Copy link
Member Author

weizhouapache commented Aug 29, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Aug 29, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache weizhouapache mentioned this pull request Aug 29, 2025
Closed
14 tasks
Pearl1594
Pearl1594 approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache weizhouapache merged commit d161dc7 into apache:4.19 Aug 29, 2025
25 checks passed
@blueorangutan
Copy link

blueorangutan commented Aug 30, 2025

[SF] Trillian test result (tid-14147)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50707 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11537-t14147-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_network_garbage_collector_nics Failure 1465.70 test_vpc_redundant.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
@weizhouapache @dhslove
api: use single quote instead of double quote in StatsResponse (apach…
41b093e 
…e#11537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@weizhouapache @blueorangutan @DaanHoogland @vishesh92 @Pearl1594 @sureshanaparti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.