Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset#11228

Merged
vishesh92 merged 4 commits intoapache:4.20apache/cloudstack:4.20from
weizhouapache:4.20-fix-password-reset-starttlsweizhouapache/cloudstack:4.20-fix-password-reset-starttlsCopy head branch name to clipboard
Oct 7, 2025
Merged

server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset#11228
vishesh92 merged 4 commits intoapache:4.20apache/cloudstack:4.20from
weizhouapache:4.20-fix-password-reset-starttlsweizhouapache/cloudstack:4.20-fix-password-reset-starttlsCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Jul 17, 2025

Description

This PR fixes #11159

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (0f0155c) to head (807dd9a).
⚠️ Report is 64 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../cloudstack/user/UserPasswordResetManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11228   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13283    13284    +1     
=========================================
  Files          5656     5656           
  Lines        497996   498002    +6     
  Branches      60401    60401           
=========================================
+ Hits          80533    80534    +1     
- Misses       408500   408506    +6     
+ Partials       8963     8962    -1
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.02% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 17, 2025

much more needed on this @weizhouapache ?

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 17, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Jul 17, 2025

much more needed on this @weizhouapache ?

@DaanHoogland
that's all, I think

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14228

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 17, 2025

@blueorangutan test keepEnv

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Jul 17, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14231

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Jul 17, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 17, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14234

@blueorangutan
Copy link

blueorangutan commented Jul 18, 2025

[SF] Trillian test result (tid-13810)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11228-t13810-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Jul 18, 2025

@DaanHoogland
I added another configuration "user.password.reset.smtp.enabledSecurityProtocols"

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 18, 2025 •
edited
Loading

@DaanHoogland I added another configuration "user.password.reset.smtp.enabledSecurityProtocols"

still looks good. ;) still needs testing though. ...

@weizhouapache weizhouapache marked this pull request as ready for review August 5, 2025 03:15
@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Aug 29, 2025

@weizhouapache also please check if this PR needs any branch or milestone changes

@weizhouapache weizhouapache changed the base branch from main to 4.20 August 29, 2025 08:34
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Aug 29, 2025

thanks @harikrishna-patnala
changed the target branch to 4.20

@sureshanaparti sureshanaparti added this to the 4.20.2 milestone Aug 29, 2025
sureshanaparti
sureshanaparti approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

vishesh92
vishesh92 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache weizhouapache changed the title server: add user.password.reset.smtp.useStartTLS for password reset server: add user.password.reset.smtp.useStartTLS and enabledSecurityProtocols for password reset Sep 12, 2025
@vishesh92
Copy link
Member

vishesh92 commented Oct 3, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 3, 2025

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 3, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15275

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 3, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 3, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 3, 2025

[SF] Trillian Build Failed (tid-14518)

@blueorangutan
Copy link

blueorangutan commented Oct 6, 2025

[SF] Trillian test result (tid-14530)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54237 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11228-t14530-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_13_retrieve_vr_default_files Error 1.12 test_diagnostics.py
test_14_retrieve_vr_one_file Error 1.12 test_diagnostics.py
test_15_retrieve_ssvm_default_files Error 1.12 test_diagnostics.py
test_16_retrieve_ssvm_single_file Error 1.12 test_diagnostics.py
test_17_retrieve_cpvm_default_files Error 1.12 test_diagnostics.py
test_18_retrieve_cpvm_single_file Error 1.12 test_diagnostics.py

vishesh92
vishesh92 approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested with mailpit after enabling STARTTLS required.

@vishesh92 vishesh92 merged commit 963a67b into apache:4.20 Oct 7, 2025
26 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-fix-password-reset-starttls branch October 7, 2025 06:27
@weizhouapache weizhouapache mentioned this pull request Oct 7, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
@weizhouapache @dhslove
server: add user.password.reset.smtp.useStartTLS and enabledSecurityP…
c32dad0 
…rotocols for password reset (apache#11228)
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025
@weizhouapache
server: add user.password.reset.smtp.useStartTLS and enabledSecurityP…
9e46ee1 
…rotocols for password reset (apache#11228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

CS 4.20.1 Password Reset Functionality Java Error

6 participants

@weizhouapache @DaanHoogland @blueorangutan @harikrishna-patnala @vishesh92 @sureshanaparti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.