bugfix ui/scripts/accounts.js L1339#1104
Closed
wolf29 wants to merge 2 commits intoapache:masterapache/cloudstack:masterfrom
Closed
bugfix ui/scripts/accounts.js L1339#1104wolf29 wants to merge 2 commits intoapache:masterapache/cloudstack:masterfrom
wolf29 wants to merge 2 commits intoapache:masterapache/cloudstack:masterfrom
Conversation
Contributor
|
@wolf29 Can you create a PR with ALL related changes ? |
Author
|
@ustcweizhou - I can. I have never done one of these before, and wanted to make sure I understood the process before doing a whole lot of changes. |
Author
|
I have added in the second fix on that file, which should also fix the generated script file, I believe. |
Member
|
LGTM, though are the additional commas causing any issue for you? |
Contributor
Member
|
@wolf29 please rebase against latest and meld commits into a single commit |
Member
|
@wolf29 can you rebase against latest master and share state of your PR, thanks LGTM tag:easypr |
Member
|
@wolf29 can you rebase |
Member
|
This needs to be rebased @wolf29 |
Contributor
|
@wolf29 Please rebase with latest master. |
Member
|
Compared diff, issue merged fixed by some other PR/person. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for one of the 2 problems in the first file in the stopper list for the https://analysis.apache.org/component_issues?id=org.apache.cloudstack%3Acloudstack#resolved=false|severities=BLOCKER