Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.20
Choose a base branch
Loading
from
Open

[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated #10975

wants to merge 1 commit into from

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jun 6, 2025

Description

This PR ensures the converted/imported instances preserve the source VM boot mode and boot type.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Verify the source VM boot type and boot mode before importing:
    image
  • Import Vmware VM using KVM host for conversion having virt-v2v and ovftool installed
  • Verify the imported VM contains the expected boot mode and boot type:
Screenshot 2025-06-05 at 22 01 49

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

nvazquez commented Jun 6, 2025

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.14%. Comparing base (823080c) to head (c2b4dc2).
Report is 5 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10975      +/-   ##
============================================
- Coverage     16.14%   16.14%   -0.01%     
- Complexity    13253    13255       +2     
============================================
  Files          5656     5656              
  Lines        497893   497897       +4     
  Branches      60374    60375       +1     
============================================
- Hits          80405    80397       -8     
- Misses       408529   408538       +9     
- Partials       8959     8962       +3
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.99% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13641

@nvazquez
Copy link
Contributor Author

nvazquez commented Jun 6, 2025

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13475)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63409 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10975-t13475-vmware-70u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_deploy_more_vms_than_limit_allows Error 150.11 test_deploy_vms_in_parallel.py
test_01_scale_vm Error 1.52 test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling Error 1.40 test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling Error 1.39 test_scale_vm.py

@nvazquez
Copy link
Contributor Author

nvazquez commented Jun 9, 2025

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13485)

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr Awaiting requested review from shwstppr

@NuxRo NuxRo Awaiting requested review from NuxRo

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees
No one assigned
Labels
component:kvm component:migration component:UI component:vmware status:has-conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvazquez @blueorangutan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.