Fix vm network throttling rate #10109
Conversation
| @@ -120,4 +126,8 @@ public void setVirtualSwitchName(String vSwitchName) { | ||
| public void setVirtualSwitchType(VirtualSwitchType vSwitchType) { | ||
| _vSwitchType = vSwitchType; | ||
| } | ||
|
|
||
| // Getter to ensure traffic shaping consistency across all NICs |
There was a problem hiding this comment.
Where and how is your variable used, at all?
There was a problem hiding this comment.
Where and how is your variable used, at all?
Hi @rohityadavcloud ,
I hope you’re doing well. I wanted to inform you that I will be working on my PR again, as I’ve encountered some issues related to the changes made. Specifically, I am addressing the problem with the vm.network.throttling.rate configuration in the cloud.configuration table.
Best regards,
Ishita
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10109 +/- ##
=============================================
- Coverage 16.06% 4.02% -12.05%
=============================================
Files 5642 394 -5248
Lines 493856 32361 -461495
Branches 59860 5713 -54147
=============================================
- Hits 79324 1301 -78023
+ Misses 405749 30912 -374837
+ Partials 8783 148 -8635
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13620 |
befe864 to
cec1464
Compare
This PR addresses the issue with the vm.network.throttling.rate configuration in the cloud.configuration table. The change includes the addition of a default value for the vm.network.throttling.rate parameter, which defines the default data transfer rate in megabits per second allowed in user VM's default network.
Added a new configuration entry:
Name: vm.network.throttling.rate
Value: 200 (Default data transfer rate)
Description: Default data transfer rate in megabits per second allowed in user VM's default network.
This PR also removes the previous guest.ip.network and guest.netmask configuration entries, as per the requirements.
Changes made:
Inserted a new entry into the cloud.configuration table for the vm.network.throttling.rate.
Deleted old configuration entries guest.ip.network and guest.netmask.
Updated necessary code references.
Note: A new branch has been created (fix-vm-network-throttling-rate) to reflect these changes.