File tree Expand file tree Collapse file tree 2 files changed +23
-1
lines changed Open diff view settings
Expand file tree Collapse file tree 2 files changed +23
-1
lines changed Open diff view settings
Original file line number Diff line number Diff line change @@ -238,7 +238,7 @@ def check_directories():
238238 prebuilt_name = get_cef_binaries_libraries_basename (OS_POSTFIX2 )
239239 print ("[build.py] ERROR: Couldn't find CEF prebuilt binaries and"
240240 " libraries: 'build/{prebuilt_dir}/'. Download it"
241- " from GitHub released tagged eg. 'v50 -upstream` or download"
241+ " from GitHub released tagged eg. 'vXX -upstream` or download"
242242 " CEF binaries from Spotify Automated Builds and then run"
243243 "`automate.py --prebuilt-cef`."
244244 .format (prebuilt_dir = prebuilt_name ))
Original file line number Diff line number Diff line change 2525import sys
2626import platform
2727import Cython
28+ import copy
2829import os
2930
3031# Must monkey patch Cython's ModuleNode to inject custom C++ code
@@ -65,6 +66,27 @@ def generate_extern_c_macro_definition(self, code):
6566 generate_extern_c_macro_definition )
6667
6768
69+ # Issue #554: Shared libraries in manylinux1 wheel should not
70+ # be linked against libpythonX.Y.so.1.0.
71+ if LINUX :
72+ get_libraries_old = (build_ext .get_libraries )
73+ def get_libraries_new (self , ext ):
74+ libraries = get_libraries_old (self , ext )
75+ libpython = ('python' + str (sys .version_info .major ) + '.'
76+ + str (sys .version_info .minor ))
77+ for lib in copy .copy (libraries ):
78+ # Library name for Python versions before 3.8 may have
79+ # an 'm' at the end.
80+ if lib .startswith (libpython ):
81+ print ("[cython_setup.py] Do not link against -l%s (Issue #554)"
82+ % lib )
83+ libraries .remove (lib )
84+ return libraries
85+ build_ext .get_libraries = (
86+ get_libraries_new
87+ )
88+
89+
6890# Command line args
6991FAST_FLAG = False
7092ENABLE_PROFILING = False
You can’t perform that action at this time.
0 commit comments