feat(util): Add bounded LRU cache utility#9141
Open
sauerdaniel wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
sauerdaniel:pr/lru-cache-boundssauerdaniel/opencode:pr/lru-cache-boundsCopy head branch name to clipboard
Open
feat(util): Add bounded LRU cache utility#9141sauerdaniel wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom sauerdaniel:pr/lru-cache-boundssauerdaniel/opencode:pr/lru-cache-boundsCopy head branch name to clipboard
sauerdaniel wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
sauerdaniel:pr/lru-cache-boundssauerdaniel/opencode:pr/lru-cache-boundsCopy head branch name to clipboard
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search results, I found one potentially related PR: Related PR:
The current PR (9141) itself appears in the search results as expected. The other results (#1163 on TUI performance, #8535 on pagination, #7036 on tool caching) are less directly related to the LRU cache utility feature. |
3 tasks
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
3 tasks
0a4888e to
e721924
Compare
Contributor
Author
|
Rebased onto latest dev (clean rebase, no conflicts).\n\nAll typechecks pass. Ready for review. |
261cf3f to
b598ff9
Compare
4f5bb89 to
59c6150
Compare
Add createLruCache() function with: - Configurable maxEntries limit to prevent unbounded growth - Optional onEvict callback for cleanup when entries are removed - Full Map-like interface (get/set/has/delete/clear/size) - Iterator support for iterating over entries
59c6150 to
2de956f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a bounded LRU (Least Recently Used) cache utility with eviction callbacks to prevent unbounded memory growth.
Fixes #9140
Problem
Several places in the codebase use unbounded
Mapobjects for caching:project/instance.tsprovider/provider.tsThese can grow without limit in long-running processes or when handling many directories/providers.
Solution
Add a reusable
createLruCacheutility that:maxEntriesoptiononEvictcallback for cleanup logicChanges
packages/opencode/src/util/cache.ts- New LRU cache utility with:maxEntrieslimit (default: Infinity for backward compatibility)onEvictcallback for disposal logiclastAccesstimestampfor...ofloopsTesting
bun turbo typecheck)Note: Manual memory testing (monitoring heap growth over time) was not performed.