fix: handle prompt abort to prevent JSON parse crash#8025
Open
ivancernja wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
Open
fix: handle prompt abort to prevent JSON parse crash#8025ivancernja wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
ivancernja wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two potentially related PRs:
These PRs appear to be addressing the same or very similar issue—handling crashes that occur when prompt/session cancellation happens and results in empty or unparseable data. PR #8025 should be reviewed against these to ensure consistency or to determine if they're duplicate efforts. |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7946
When cancel() rejects the prompt callback, the stream closes without writing anything. SDK then crashes parsing empty body.
This catches the rejection and writes null instead.
Couldn't reproduce locally but the fix seems correct based on the code flow.