fix(tui): handle undefined agent.current() to prevent fatal TypeError#7689
Open
peremajoral wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
peremajoral:fix/agent-current-undefinedperemajoral/opencode:fix/agent-current-undefinedCopy head branch name to clipboard
Open
fix(tui): handle undefined agent.current() to prevent fatal TypeError#7689peremajoral wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom peremajoral:fix/agent-current-undefinedperemajoral/opencode:fix/agent-current-undefinedCopy head branch name to clipboard
peremajoral wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
peremajoral:fix/agent-current-undefinedperemajoral/opencode:fix/agent-current-undefinedCopy head branch name to clipboard
Conversation
When the agents list is empty or the stored agent name doesn't match any available agent, local.agent.current() returns undefined. Accessing .name on undefined causes TypeError: undefined is not an object. Changes: - local.tsx: Add optional chaining and null guards throughout - prompt/index.tsx: Add optional chaining with build fallback - dialog-agent.tsx: Add optional chaining with empty string fallback Fixes: opentui: fatal: undefined is not an object
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
This was referenced Jan 11, 2026
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the fatal error:
TypeError: undefined is not an object (evaluating 'local.agent.current().name')Root Cause
When the agents list is empty or the stored agent name doesn't match any available agent,
local.agent.current()returnsundefined. The code then crashes when accessing.nameonundefined.Affected locations:
packages/opencode/src/cli/cmd/tui/context/local.tsx- Source of the issuepackages/opencode/src/cli/cmd/tui/component/prompt/index.tsx- 6 consumer locationspackages/opencode/src/cli/cmd/tui/component/dialog-agent.tsx- 1 consumer locationChanges
local.tsxagents()[0].name→agents()[0]?.name ?? ""for safe initialization!fromcurrent()returnagent.current()prompt/index.tsx"build"fallback at all 6 locations:dialog-agent.tsxTesting
The fix adds defensive null checks that gracefully handle edge cases without changing normal behavior when agents are properly loaded.