Make the MAX_OUTPUT_LENGTH in bash.ts overridable by env variable.#4497
Make the MAX_OUTPUT_LENGTH in bash.ts overridable by env variable.#4497rekram1-node merged 5 commits intoanomalyco:devanomalyco/opencode:devfrom cc-bjojac:max_output_length_overridablecc-bjojac/opencode:max_output_length_overridableCopy head branch name to clipboard
Conversation
|
I feel like a variable with this name would apply to other tools as well, (even tho in your pr it isn't) is that your intention or should we make it bash tool specific? |
|
My intention was to do it only for the bash tool to be honest. I can make the env parameter name more specific like |
|
/oc adjust the env var to be prefixed by OPENCODE_EXPERIMENTAL_ instead of just OPENCODE_ Update both files |
|
Updated both files to use |
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
|
I'm going to make this experimental for now because ideally the settings should all be configurable in a much better way. Experimental doesnt mean im getting rid of it next week it's just so that we dont have to be committed to this var forever |
The motivation behind this is that when opencode executes my tests in a large project, it truncates the output at some point. I was not able to see what test actually failed in the console.
I made the parameter overridable by an env variable with fallback to the original hard-coded value if it is not present or could not be parsed.