feat: Add "system.prompt.append" hook#4142
Closed
frap129 wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
frap129:feat/system-prompt-append-hookfrap129/opencode:feat/system-prompt-append-hookCopy head branch name to clipboard
Closed
feat: Add "system.prompt.append" hook#4142frap129 wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom frap129:feat/system-prompt-append-hookfrap129/opencode:feat/system-prompt-append-hookCopy head branch name to clipboard
frap129 wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
frap129:feat/system-prompt-append-hookfrap129/opencode:feat/system-prompt-append-hookCopy head branch name to clipboard
Conversation
772b621 to
eb855e1
Compare
f1dc981 to
3e15a39
Compare
f8ee907 to
6a9856d
Compare
|
Hi, I would much rather have a generic system prompt hook that takes the whole system prompt and let's me do whatever i want with it. Not just append only. Power to the people! :) |
Author
|
#5542 implements the same functionality, closing since it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new hook for the plugin system, "system.prompt.append", to allow appending instructions to the system prompt between messages. The primarily use case for this is to allow plugins to add system instructions dynamically, based on context.
I attempted to write a plugin to implement cursor-style rules, that can always be inserted or inserted when certain glob patterns are matched. With the plugin system as it is currently, the best way to insert these rules was through user messages with noReply set. Thus, rules can only be added, not removed, and are lost when the conversation is compacted. With this hook, rules can be added dynamically as needed, without polluting the chat history with messages.
This is just a first pass of something that works, and I'm looking for feedback on how this can be improved, or if it is even wanted by the team.