Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix: Autocomplete with existing space after trigger#4121

Merged
rekram1-node merged 6 commits intoanomalyco:devanomalyco/opencode:devfrom
veracioux:fix/autocomplete-space-after-triggerveracioux/opencode:fix/autocomplete-space-after-triggerCopy head branch name to clipboard
Nov 20, 2025
Merged

fix: Autocomplete with existing space after trigger#4121
rekram1-node merged 6 commits intoanomalyco:devanomalyco/opencode:devfrom
veracioux:fix/autocomplete-space-after-triggerveracioux/opencode:fix/autocomplete-space-after-triggerCopy head branch name to clipboard

Conversation

@veracioux
Copy link
Contributor

@veracioux veracioux commented Nov 9, 2025

Fixes #4120.
Fixes #4523.

Changes:

  • The mechanism that closes the autocomplete after the user types a space after the @ trigger is now event-driven, instead of state-driven (to prevent existing text after the @ trigger from hiding the autocomplete)
  • Avoided side-effect inside memo, which is an anti-pattern

This is on my radar to add comprehensive TUI tests for. There are already a few for Autocomplete.
I did test my change thoroughly manually though.

@rekram1-node
Copy link
Collaborator

@veracioux can u fix the test and typecheck?

@rekram1-node
Copy link
Collaborator

Or rebase / merge dev ig maybe its just out of date

@veracioux
Copy link
Contributor Author

Done

@rekram1-node
Copy link
Collaborator

Tested quite a lot, I think this ones good to go, thanks @veracioux

@rekram1-node rekram1-node merged commit b1b73c9 into anomalyco:dev Nov 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to reference files mid sentence when typing @ after a space Autocomplete a filename did not work on old prompt

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.