fix(opencode): Avoid default port 4096 in ACP mode#14498
Open
rschaeuble wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
Open
fix(opencode): Avoid default port 4096 in ACP mode#14498rschaeuble wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
rschaeuble wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
e2e test failure seems to be unrelated to my changes. Probably caused by upstream issues ("bad gateway"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
opencode webrelies on a stable origin (hostname:port) for browser localStorage, so it is expected to run onlocalhost:4096by default.opencode acpcurrently shares server startup behavior that prefers port4096when no port is explicitly configured. When ACP starts first (for example from IntelliJ), it can claim4096, causingopencode webto fall back to a random port and use a different localStorage origin.This creates a misconfigured web experience because preferences are split across origins.
Closes #14500
Type of change
What does this PR do?
For call sites except ACP nothing changes. Unless explicitely configured, port 4096 is preferred.
ACP passes a new flag that tells Server.listen to not default to port 4096.
How did you verify your code works?
I ran
bun run --cwd packages/opencode --conditions=browser src/index.ts acp. Before the change, it used port 4096 (when it was available). After the change it now uses a random port.Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.