From fa0144f47e1f388b426a578f2580dc052a421ca0 Mon Sep 17 00:00:00 2001 From: Silvio Ney Date: Mon, 16 Feb 2026 15:58:00 +0000 Subject: [PATCH] feat: add setActive method to input and update related functionality --- packages/app/src/pages/session.tsx | 1 + packages/app/src/pages/session/helpers.test.ts | 3 ++- packages/app/src/pages/session/helpers.ts | 5 ++++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/app/src/pages/session.tsx b/packages/app/src/pages/session.tsx index d958990c25ab..a4c2641af464 100644 --- a/packages/app/src/pages/session.tsx +++ b/packages/app/src/pages/session.tsx @@ -918,6 +918,7 @@ export default function Page() { tabForPath: file.tab, openTab: tabs().open, loadFile: file.load, + setActive: tabs().setActive, }) const changesOptions = ["session", "turn"] as const diff --git a/packages/app/src/pages/session/helpers.test.ts b/packages/app/src/pages/session/helpers.test.ts index 8b9746507ef3..dfe7ca757db8 100644 --- a/packages/app/src/pages/session/helpers.test.ts +++ b/packages/app/src/pages/session/helpers.test.ts @@ -12,11 +12,12 @@ describe("createOpenReviewFile", () => { }, openTab: (tab) => calls.push(`open:${tab}`), loadFile: (path) => calls.push(`load:${path}`), + setActive: (tab) => calls.push(`active:${tab}`), }) openReviewFile("src/a.ts") - expect(calls).toEqual(["show", "tab:src/a.ts", "open:file://src/a.ts", "load:src/a.ts"]) + expect(calls).toEqual(["tab:src/a.ts", "show", "open:file://src/a.ts", "load:src/a.ts", "active:file://src/a.ts"]) }) }) diff --git a/packages/app/src/pages/session/helpers.ts b/packages/app/src/pages/session/helpers.ts index 5ca355d1d291..f210af1be610 100644 --- a/packages/app/src/pages/session/helpers.ts +++ b/packages/app/src/pages/session/helpers.ts @@ -25,13 +25,16 @@ export const createOpenReviewFile = (input: { tabForPath: (path: string) => string openTab: (tab: string) => void loadFile: (path: string) => void + setActive: (tab: string) => void }) => { return (path: string) => { + const tab = input.tabForPath(path) batch(() => { input.showAllFiles() - input.openTab(input.tabForPath(path)) + input.openTab(tab) input.loadFile(path) }) + input.setActive(tab) } }