-
Notifications
You must be signed in to change notification settings - Fork 0
Homework week3 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mattiaslundberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homework/index.js
Outdated
|
|
||
| async function main(url) { | ||
| try { | ||
| const repositoryData = await fetchJSON(url); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The async/await rewrite looks good!
homework/App.js
Outdated
|
|
||
| async initialize(url) { | ||
| const root = document.getElementById('root'); | ||
| Util.createAndAppend('h1', root, { text: 'REPOSITORES' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't pass you on this part. You need to use the classes Contributor and Repository with the appropriate render methods, this is important to understand before the react module. Let me know if you need any assistance with this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright :) I have watched a bunch of tutorials on this and hope to finally to be able to solve it especially since we got even more additional guidance on Slack. It takes a while to find out how these all .js files are connected, but once I understand it, I hope to be able to use it over and over again in the future projects. My main issue is being able to put apart and use small parts of the huge functions without damaging the functionality.
mattiaslundberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.