Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@annagabain
Copy link
Owner

No description provided.

@annagabain annagabain changed the title async-await- try-catch Homework week3 Sep 1, 2019
Copy link

@mattiaslundberg mattiaslundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close


async function main(url) {
try {
const repositoryData = await fetchJSON(url);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The async/await rewrite looks good!

homework/App.js Outdated

async initialize(url) {
const root = document.getElementById('root');
Util.createAndAppend('h1', root, { text: 'REPOSITORES' });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't pass you on this part. You need to use the classes Contributor and Repository with the appropriate render methods, this is important to understand before the react module. Let me know if you need any assistance with this!

Copy link
Owner Author

@annagabain annagabain Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright :) I have watched a bunch of tutorials on this and hope to finally to be able to solve it especially since we got even more additional guidance on Slack. It takes a while to find out how these all .js files are connected, but once I understand it, I hope to be able to use it over and over again in the future projects. My main issue is being able to put apart and use small parts of the huge functions without damaging the functionality.

Copy link

@mattiaslundberg mattiaslundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.