Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f1213e3

Browse filesBrowse files
committed
ci: enable e2e test runs on Node.js 24
This update configures the CI pipeline to execute e2e tests using Node.js v24. (cherry picked from commit 7b25900)
1 parent a3e35ee commit f1213e3
Copy full SHA for f1213e3

File tree

Expand file treeCollapse file tree

3 files changed

+21
-1
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+21
-1
lines changed

‎.github/workflows/ci.yml

Copy file name to clipboardExpand all lines: .github/workflows/ci.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
fail-fast: false
8282
matrix:
8383
os: [ubuntu-latest]
84-
node: [20, 22]
84+
node: [20, 22, 24]
8585
subset: [npm, esbuild]
8686
shard: [0, 1, 2, 3, 4, 5]
8787
runs-on: ${{ matrix.os }}

‎WORKSPACE

Copy file name to clipboardExpand all lines: WORKSPACE
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,20 @@ nodejs_register_toolchains(
101101
node_version = "22.11.0",
102102
)
103103

104+
nodejs_register_toolchains(
105+
name = "node24",
106+
node_repositories = {
107+
"24.0.0-darwin_arm64": ("node-v24.0.0-darwin-arm64.tar.gz", "node-v24.0.0-darwin-arm64", "194e2f3dd3ec8c2adcaa713ed40f44c5ca38467880e160974ceac1659be60121"),
108+
"24.0.0-darwin_amd64": ("node-v24.0.0-darwin-x64.tar.gz", "node-v24.0.0-darwin-x64", "f716b3ce14a7e37a6cbf97c9de10d444d7da07ef833cd8da81dd944d111e6a4a"),
109+
"24.0.0-linux_arm64": ("node-v24.0.0-linux-arm64.tar.xz", "node-v24.0.0-linux-arm64", "d40ec7ffe0b82b02dce94208c84351424099bd70fa3a42b65c46d95322305040"),
110+
"24.0.0-linux_ppc64le": ("node-v24.0.0-linux-ppc64le.tar.xz", "node-v24.0.0-linux-ppc64le", "cfa0e8d51a2f9a446f1bfb81cdf4c7e95336ad622e2aa230e3fa1d093c63d77d"),
111+
"24.0.0-linux_s390x": ("node-v24.0.0-linux-s390x.tar.xz", "node-v24.0.0-linux-s390x", "e37a04c7ee05416ec1234fd3255e05b6b81287eb0424a57441c8b69f0a155021"),
112+
"24.0.0-linux_amd64": ("node-v24.0.0-linux-x64.tar.xz", "node-v24.0.0-linux-x64", "59b8af617dccd7f9f68cc8451b2aee1e86d6bd5cb92cd51dd6216a31b707efd7"),
113+
"24.0.0-windows_amd64": ("node-v24.0.0-win-x64.zip", "node-v24.0.0-win-x64", "3d0fff80c87bb9a8d7f49f2f27832aa34a1477d137af46f5b14df5498be81304"),
114+
},
115+
node_version = "24.0.0",
116+
)
117+
104118
load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
105119

106120
rules_js_register_toolchains(

‎tools/toolchain_info.bzl

Copy file name to clipboardExpand all lines: tools/toolchain_info.bzl
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
TOOLCHAINS_NAMES = [
66
"node20",
77
"node22",
8+
"node24",
89
]
910

1011
# this is the list of toolchains that should be used and are registered with nodejs_register_toolchains in the WORKSPACE file
@@ -19,6 +20,11 @@ TOOLCHAINS_VERSIONS = [
1920
"@bazel_tools//src/conditions:darwin": "@node22_darwin_amd64//:node_toolchain",
2021
"@bazel_tools//src/conditions:windows": "@node22_windows_amd64//:node_toolchain",
2122
}),
23+
select({
24+
"@bazel_tools//src/conditions:linux_x86_64": "@node24_linux_amd64//:node_toolchain",
25+
"@bazel_tools//src/conditions:darwin": "@node24_darwin_amd64//:node_toolchain",
26+
"@bazel_tools//src/conditions:windows": "@node24_windows_amd64//:node_toolchain",
27+
}),
2228
]
2329

2430
# A default toolchain for use when only one is necessary

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.