fix(adev): reset webcontainer counter when user dismisses OOM warning#67371
Open
flowerjunjie wants to merge 1 commit intoangular:mainangular/angular:mainfrom
Open
fix(adev): reset webcontainer counter when user dismisses OOM warning#67371flowerjunjie wants to merge 1 commit intoangular:mainangular/angular:mainfrom
flowerjunjie wants to merge 1 commit intoangular:mainangular/angular:mainfrom
Conversation
When an OOM error occurs in Safari, the tab may be automatically reloaded without firing the beforeunload event, causing the webcontainer counter to not decrease. This results in false positive OOM warnings even when the user has fewer than 3 tabs open. This fix resets the webcontainer counter to 0 when the user dismisses the OOM warning snackbar, ensuring the counter is accurate after an OOM-related page reload. Fixes angular#52647
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52647
Problem
When an OOM error occurs in Safari, the tab may be automatically reloaded without firing the
beforeunloadevent. This causes the webcontainer counter to not decrease, resulting in false positive OOM warnings even when the user has fewer than 3 tabs open.Solution
Reset the webcontainer counter to 0 when the user dismisses the OOM warning snackbar. This ensures the counter is accurate after an OOM-related page reload.
Changes
afterDismissed()event on the snackbar referenceresetWebcontainerCounter()when the snackbar is dismissedWEBCONTAINERS_COUNTER_KEYto 0 in localStorageTesting