Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(devtools): inspect signals #61540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(devtools): inspect signals #61540

wants to merge 1 commit into from

Conversation

milomg
Copy link
Contributor

@milomg milomg commented May 20, 2025 •
edited
Loading

add a new global api for the devtools connector to jump to the source of a computed or effect

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

We can now call ApplicationOperations.inspectSignal from chrome devtools and it will jump to the source of a computed or effect

See #60478 for a more complete demo

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dgp1130 May 20, 2025 21:16
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels May 20, 2025
@ngbot ngbot bot added this to the Backlog milestone May 20, 2025
@milomg milomg mentioned this pull request May 20, 2025
Closed
14 tasks
dgp1130
dgp1130 approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only some minor suggestions.

devtools/projects/shell-browser/src/app/chrome-window-extensions.ts Show resolved Hide resolved
devtools/projects/shell-browser/src/app/chrome-window-extensions.ts Show resolved Hide resolved
devtools/projects/shell-browser/src/app/chrome-window-extensions.ts Show resolved Hide resolved
@milomg
feat(devtools): inspect signals
acb4d84 
add a new global api for the devtools connector to jump to the source of
a computed or effect
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 1, 2025
@kirjs
Copy link
Contributor

kirjs commented Jun 2, 2025

This PR was merged into the repository by commit 6f16d92.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 6f16d92 Jun 2, 2025
@milomg milomg deleted the signal-graph-2 branch June 3, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes

@AleksanderBodurri AleksanderBodurri AleksanderBodurri approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@milomg @kirjs @dgp1130 @AleksanderBodurri @JeanMeche
Morty Proxy This is a proxified and sanitized view of the page, visit original site.