Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

refactor(core): Disallow autoDetectChanges(false) in zoneless #61430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions 7 packages/core/test/component_fixture_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ describe('ComponentFixture with zoneless', () => {
expect(() => fixture.detectChanges()).toThrowError(/ExpressionChanged/);
});

it('runs change detection when autoDetect is false', () => {
it('disallows autoDetect: false', () => {
@Component({
template: '{{thing()}}',
})
Expand All @@ -643,9 +643,6 @@ describe('ComponentFixture with zoneless', () => {
}

const fixture = TestBed.createComponent(App);
fixture.autoDetectChanges(false);
fixture.componentInstance.thing.set(2);
fixture.detectChanges();
expect(fixture.nativeElement.innerText).toBe('2');
expect(() => fixture.autoDetectChanges(false)).toThrow();
});
});
3 changes: 3 additions & 0 deletions 3 packages/core/testing/src/component_fixture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ export class ComponentFixture<T> {
*/
autoDetectChanges(): void;
autoDetectChanges(autoDetect = true): void {
if (!autoDetect && this.zonelessEnabled) {
throw new Error('Cannot set autoDetect to false with zoneless change detection.');
}
if (this._noZoneOptionIsSet && !this.zonelessEnabled) {
throw new Error('Cannot call autoDetectChanges when ComponentFixtureNoNgZone is set.');
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.