-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[20.0.x] build: migrate adev to use ng_project #61345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.0.x] build: migrate adev to use ng_project #61345
Conversation
Move all of adev to use ng_project instead of ng_module
Move ts_project and ng_project into a macro for adev/ instead of providing a custom tsconfig on every target
87599fb
to
3d28913
Compare
], | ||
substitutions = { | ||
# Force the "unstamped" versions to be later than current so they are considered up to date. | ||
"0.0.0": "99.99.99", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did this work before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is another artifact of the weird "unstamped" versions when we do things locally. Previously it would stamp as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I've left a final review comment on that in the main PR.
Move all of adev to use ng_project instead of ng_module PR Close #61345
Move ts_project and ng_project into a macro for adev/ instead of providing a custom tsconfig on every target PR Close #61345
This PR was merged into the repository by commit 82b51c6. The changes were merged into the following branches: 20.0.x |
No description provided.