Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[20.0.x] build: migrate adev to use ng_project #61345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott requested a review from devversion May 14, 2025 16:33
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate labels May 14, 2025
@ngbot ngbot bot added this to the Backlog milestone May 14, 2025
@thePunderWoman thePunderWoman removed the action: merge The PR is ready for merge by the caretaker label May 16, 2025
Move all of adev to use ng_project instead of ng_module
Move ts_project and ng_project into a macro for adev/ instead of providing a custom
tsconfig on every target
@josephperrott josephperrott force-pushed the migrate-adev-ng-project-rc branch from 87599fb to 3d28913 Compare May 19, 2025 21:00
],
substitutions = {
# Force the "unstamped" versions to be later than current so they are considered up to date.
"0.0.0": "99.99.99",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this work before?

Copy link
Member Author

@josephperrott josephperrott May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is another artifact of the weird "unstamped" versions when we do things locally. Previously it would stamp as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've left a final review comment on that in the main PR.

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels May 20, 2025
@devversion devversion marked this pull request as ready for review May 20, 2025 09:08
thePunderWoman pushed a commit that referenced this pull request May 20, 2025
Move all of adev to use ng_project instead of ng_module

PR Close #61345
thePunderWoman pushed a commit that referenced this pull request May 20, 2025
Move ts_project and ng_project into a macro for adev/ instead of providing a custom
tsconfig on every target

PR Close #61345
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 82b51c6.

The changes were merged into the following branches: 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.