refactor(compiler): account for pipes without names #61328
Conversation
| export declare class PipeWithoutName implements PipeTransform { | ||
| transform(value: unknown): unknown; | ||
| static ɵfac: i0.ɵɵFactoryDeclaration<PipeWithoutName, never>; | ||
| static ɵpipe: i0.ɵɵPipeDeclaration<PipeWithoutName, null, true>; |
There was a problem hiding this comment.
I'm curious, do you have thoughts this output appearing in projects using an older compiler version? I don't fully recall what our version guarantees here are (which way, backwards, forward etc.).
Likely simply not picking up the pipe metadata is the expected behavior here.
There was a problem hiding this comment.
Hmm not entirely sure either, but I suspect that we don't support this sort of backwards compatibility.
There was a problem hiding this comment.
Yeah, it's probably fine because there is no way to reference the pipe nicely "without" a name; but might be worth double-checking with others.
Worst-case, we could roll out changes to older compilers and error if we discover a nameless pipe when collecting metadata for a symbol via .d.ts
There was a problem hiding this comment.
Reporting an error when used with older compilers can be done by changing the minVersion value of the partial declaration, that's what it's designed for.
| } | ||
| } | ||
| PipeWithoutName.ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "0.0.0-PLACEHOLDER", ngImport: i0, type: PipeWithoutName, deps: [], target: i0.ɵɵFactoryTarget.Pipe }); | ||
| PipeWithoutName.ɵpipe = i0.ɵɵngDeclarePipe({ minVersion: "14.0.0", version: "0.0.0-PLACEHOLDER", ngImport: i0, type: PipeWithoutName, isStandalone: true, name: "PipeWithoutName" }); |
There was a problem hiding this comment.
Also, just to be safe, you did choose the name to be still emitted for backwards compatibility of such "nameless pipe" partial compilation output, right?
There was a problem hiding this comment.
Yeah I left it for backwards compatibility and because this is the name that the runtime will use to "match" pipes.
|
There were some discussions over whether we want to do the public API change now. I've dropped it for the moment and will leave the rest of the compiler code so that we can easily make the switch later. |
6daab46 to
9a873cc
Compare
Updates the compiler logic to account for pipe definitions that may not have names.
Updates the compiler logic to account for pipe definitions that may not have names.