fix(core): cleanup testability subscriptions #61261
Open
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
May 11, 2025
| }), | ||
| ); | ||
|
|
||
| this._destroyRef.onDestroy(() => { |
There was a problem hiding this comment.
Wouldn't takeUntilDetroyed be more adequate ?
There was a problem hiding this comment.
It becomes a circular dependency (core depends on rxjs-interop and vice versa).
devversion
approved these changes
May 12, 2025
|
@arturovt Looks like there's a circular dependency added here. |
9660fe5 to
c1dff20
Compare
This commit prevents leaking memory when the application is destroyed and subscriptions are still alive.
c1dff20 to
bc57aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents leaking memory when the application is destroyed and subscriptions are still alive.