fix(animations): add missing peer dependency on @angular/common
#60660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of angular@1c4a367#diff-64131f78c9ae21421dc277debf9c8a16705a90fa649ddf580da3db434c295b11R7-R8, the animations package has a dependency on `@angular/common`. This commit adds this dependency to the `package.json`— as otherwise pnpm strict builds will fail.
crisbeto
approved these changes
Apr 1, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 1, 2025
…0660) As of 1c4a367#diff-64131f78c9ae21421dc277debf9c8a16705a90fa649ddf580da3db434c295b11R7-R8, the animations package has a dependency on `@angular/common`. This commit adds this dependency to the `package.json`— as otherwise pnpm strict builds will fail. PR Close #60660
Contributor
|
This PR was merged into the repository by commit 5eccf3a. The changes were merged into the following branches: main, 19.2.x |
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 1, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 1, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 1, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 2, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 2, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 2, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 2, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 2, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to angular/components
that referenced
this pull request
Apr 2, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 3, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 3, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 3, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to devversion/material2
that referenced
this pull request
Apr 3, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
devversion
added a commit
to angular/components
that referenced
this pull request
Apr 3, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
mistrykaran91
pushed a commit
to mistrykaran91/components
that referenced
this pull request
Apr 7, 2025
…eer dep This is necessary until a new version of the animations package is published. See: angular/angular#60660
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 1c4a367#diff-64131f78c9ae21421dc277debf9c8a16705a90fa649ddf580da3db434c295b11R7-R8, the animations package has a dependency on
@angular/common. This commit adds this dependency to thepackage.json— as otherwise pnpm strict builds will fail.