fix(compiler): allow TS jsDocParsingMode host option to be programmatically set again#53292
Closed
clydin wants to merge 1 commit intoangular:mainangular/angular:mainfrom
clydin:compiler/jsdocparsingmodeclydin/angular:compiler/jsdocparsingmodeCopy head branch name to clipboard
Closed
fix(compiler): allow TS jsDocParsingMode host option to be programmatically set again#53292clydin wants to merge 1 commit intoangular:mainangular/angular:mainfrom clydin:compiler/jsdocparsingmodeclydin/angular:compiler/jsdocparsingmodeCopy head branch name to clipboard
clydin wants to merge 1 commit intoangular:mainangular/angular:mainfrom
clydin:compiler/jsdocparsingmodeclydin/angular:compiler/jsdocparsingmodeCopy head branch name to clipboard
Conversation
…ically set again When the AOT compiler creates a delegated host for a provided TypeScript CompilerHost, it delegates functionality back to the original via a series of internal method delegations. However, unlike other members of the CompilerHost, `jsDocParsingMode` is not a method and cannot be delegated in this way. Attempting to call bind on the property will result in a runtime error. Instead, `jsDocParsingMode` is now delegated via get/set accessors. Additionally, the override of `getSourceFile` now has an updated type signature to reflect the additional of the `jsDocParsingMode` option for the method. This is a followup to angular#53126 which updates the other DelegatingCompilerHost.
crisbeto
approved these changes
Nov 30, 2023
Contributor
|
This PR was merged into the repository by commit 5613051. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ically set again (angular#53292) When the AOT compiler creates a delegated host for a provided TypeScript CompilerHost, it delegates functionality back to the original via a series of internal method delegations. However, unlike other members of the CompilerHost, `jsDocParsingMode` is not a method and cannot be delegated in this way. Attempting to call bind on the property will result in a runtime error. Instead, `jsDocParsingMode` is now delegated via get/set accessors. Additionally, the override of `getSourceFile` now has an updated type signature to reflect the additional of the `jsDocParsingMode` option for the method. This is a followup to angular#53126 which updates the other DelegatingCompilerHost. PR Close angular#53292
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…ically set again (angular#53292) When the AOT compiler creates a delegated host for a provided TypeScript CompilerHost, it delegates functionality back to the original via a series of internal method delegations. However, unlike other members of the CompilerHost, `jsDocParsingMode` is not a method and cannot be delegated in this way. Attempting to call bind on the property will result in a runtime error. Instead, `jsDocParsingMode` is now delegated via get/set accessors. Additionally, the override of `getSourceFile` now has an updated type signature to reflect the additional of the `jsDocParsingMode` option for the method. This is a followup to angular#53126 which updates the other DelegatingCompilerHost. PR Close angular#53292
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…ically set again (angular#53292) When the AOT compiler creates a delegated host for a provided TypeScript CompilerHost, it delegates functionality back to the original via a series of internal method delegations. However, unlike other members of the CompilerHost, `jsDocParsingMode` is not a method and cannot be delegated in this way. Attempting to call bind on the property will result in a runtime error. Instead, `jsDocParsingMode` is now delegated via get/set accessors. Additionally, the override of `getSourceFile` now has an updated type signature to reflect the additional of the `jsDocParsingMode` option for the method. This is a followup to angular#53126 which updates the other DelegatingCompilerHost. PR Close angular#53292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Attempting to set the
jsDocParsingModeoption on a TSCompilerHostinstance will currently result in the following error:TypeError: this.delegate[name].bind is not a functionThis prevents the Angular CLI from adjusting this value.
Issue Number: N/A
What is the new behavior?
When the AOT compiler creates a delegated host for a provided TypeScript CompilerHost, it delegates functionality back to the original via a series of internal method delegations. However, unlike other members of the CompilerHost,
jsDocParsingModeis not a method and cannot be delegated in this way. Attempting to call bind on the property will result in a runtime error. Instead,jsDocParsingModeis now delegated via get/set accessors. Additionally, the override ofgetSourceFilenow has an updated type signature to reflect the additional of thejsDocParsingModeoption for the method.Does this PR introduce a breaking change?
Other information
This is a followup to #53126 which updates the other DelegatingCompilerHost.