Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Revert template diagnostic PR#53012

Closed
crisbeto wants to merge 4 commits intoangular:mainangular/angular:mainfrom
crisbeto:revert-diagnosticcrisbeto/angular:revert-diagnosticCopy head branch name to clipboard
Closed

Revert template diagnostic PR#53012
crisbeto wants to merge 4 commits intoangular:mainangular/angular:mainfrom
crisbeto:revert-diagnosticcrisbeto/angular:revert-diagnosticCopy head branch name to clipboard

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 17, 2023

These changes revert #52726 because it caused some issues internally.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Nov 17, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 17, 2023
@pullapprove pullapprove bot requested review from atscott and dylhunn November 17, 2023 19:35
@pullapprove pullapprove bot requested a review from jessicajaniuk November 17, 2023 19:37
@jessicajaniuk jessicajaniuk added PullApprove: disable action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2023
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 17, 2023

This PR was merged into the repository by commit f63c0f6.

AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "refactor(compiler-cli): expose ng-content selectors and prese…
715218a 
…rveWhitespaces during template type checking (#52726)" (#53012)

This reverts commit 4550a81.

PR Close #53012
AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "test(core): add tests for control flow content projection wit…
6f67d0c 
…h ng-container (#52726)" (#53012)

This reverts commit 181f8e4.

PR Close #53012
AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "fix(compiler-cli): add diagnostic for control flow that preve…
f63c0f6 
…nts content projection (#52726)" (#53012)

This reverts commit b4d022e.

PR Close #53012
AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "refactor(compiler): expose utility for creating CSS selectors…
cf0a0f3 
… from AST nodes (#52726)" (#53012)

This reverts commit adbea7b.

PR Close #53012
AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "refactor(compiler-cli): expose ng-content selectors and prese…
cfcce8c 
…rveWhitespaces during template type checking (#52726)" (#53012)

This reverts commit 4550a81.

PR Close #53012
AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "test(core): add tests for control flow content projection wit…
f6a9292 
…h ng-container (#52726)" (#53012)

This reverts commit 181f8e4.

PR Close #53012
AndrewKushnir pushed a commit that referenced this pull request Nov 17, 2023
@crisbeto @AndrewKushnir
Revert "fix(compiler-cli): add diagnostic for control flow that preve…
6df5f0e 
…nts content projection (#52726)" (#53012)

This reverts commit b4d022e.

PR Close #53012
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 18, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
Revert "refactor(compiler): expose utility for creating CSS selectors…
822ddda 
… from AST nodes (angular#52726)" (angular#53012)

This reverts commit adbea7b.

PR Close angular#53012
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
Revert "refactor(compiler-cli): expose ng-content selectors and prese…
cead80b 
…rveWhitespaces during template type checking (angular#52726)" (angular#53012)

This reverts commit 4550a81.

PR Close angular#53012
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
Revert "test(core): add tests for control flow content projection wit…
9790908 
…h ng-container (angular#52726)" (angular#53012)

This reverts commit 181f8e4.

PR Close angular#53012
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@crisbeto @ChellappanRajan
Revert "fix(compiler-cli): add diagnostic for control flow that preve…
520d2ea 
…nts content projection (angular#52726)" (angular#53012)

This reverts commit b4d022e.

PR Close angular#53012
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@crisbeto @rlmestre
Revert "refactor(compiler): expose utility for creating CSS selectors…
7dc6930 
… from AST nodes (angular#52726)" (angular#53012)

This reverts commit adbea7b.

PR Close angular#53012
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@crisbeto @rlmestre
Revert "refactor(compiler-cli): expose ng-content selectors and prese…
35008b9 
…rveWhitespaces during template type checking (angular#52726)" (angular#53012)

This reverts commit 4550a81.

PR Close angular#53012
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@crisbeto @rlmestre
Revert "test(core): add tests for control flow content projection wit…
cbfd6f2 
…h ng-container (angular#52726)" (angular#53012)

This reverts commit 181f8e4.

PR Close angular#53012
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@crisbeto @rlmestre
Revert "fix(compiler-cli): add diagnostic for control flow that preve…
8c6793e 
…nts content projection (angular#52726)" (angular#53012)

This reverts commit b4d022e.

PR Close angular#53012
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@crisbeto @amilamen
Revert "refactor(compiler): expose utility for creating CSS selectors…
e956299 
… from AST nodes (angular#52726)" (angular#53012)

This reverts commit adbea7b.

PR Close angular#53012
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@crisbeto @amilamen
Revert "refactor(compiler-cli): expose ng-content selectors and prese…
fb426c3 
…rveWhitespaces during template type checking (angular#52726)" (angular#53012)

This reverts commit 4550a81.

PR Close angular#53012
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@crisbeto @amilamen
Revert "test(core): add tests for control flow content projection wit…
7f34234 
…h ng-container (angular#52726)" (angular#53012)

This reverts commit 181f8e4.

PR Close angular#53012
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@crisbeto @amilamen
Revert "fix(compiler-cli): add diagnostic for control flow that preve…
66f2c55 
…nts content projection (angular#52726)" (angular#53012)

This reverts commit b4d022e.

PR Close angular#53012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@atscott atscott Awaiting requested review from atscott

@dylhunn dylhunn Awaiting requested review from dylhunn

@jessicajaniuk jessicajaniuk Awaiting requested review from jessicajaniuk

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @AndrewKushnir @jessicajaniuk
Morty Proxy This is a proxified and sanitized view of the page, visit original site.