fix(common): apply fixed_srcset_width value only to fixed srcsets#52459
Closed
atcastle wants to merge 1 commit intoangular:mainangular/angular:mainfrom
atcastle:fix-srcset-size-limitatcastle/angular:fix-srcset-size-limitCopy head branch name to clipboard
Closed
fix(common): apply fixed_srcset_width value only to fixed srcsets#52459atcastle wants to merge 1 commit intoangular:mainangular/angular:mainfrom atcastle:fix-srcset-size-limitatcastle/angular:fix-srcset-size-limitCopy head branch name to clipboard
atcastle wants to merge 1 commit intoangular:mainangular/angular:mainfrom
atcastle:fix-srcset-size-limitatcastle/angular:fix-srcset-size-limitCopy head branch name to clipboard
Conversation
add logic to NgOptimizedImage to keep fixed_srcset_width from applying to large responsive images, which is incorrect behavior
AndrewKushnir
approved these changes
Oct 30, 2023
Contributor
Contributor
|
Caretaker note: the presubmit is "green" (only unrelated failures), this PR is ready for merge. |
Member
|
This PR was merged into the repository by commit f86fb8e. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…gular#52459) add logic to NgOptimizedImage to keep fixed_srcset_width from applying to large responsive images, which is incorrect behavior PR Close angular#52459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in NgOptimizedImage where the FIXED_SRCSET_WIDTH_LIMIT was being applied to both "fixed" and "responsive" srcsets. As the constant name indicates, this is only supposed to apply to fixed images. For responsive images, not generating the srcset in this case is an antipattern, as it prevents the automatic srcset from correctly suggesting a smaller version of the image.
New tests included to prevent regression. CC: @AndrewKushnir @kara