fix(router): RouterTestingHarness should throw if a component is ex…#52357
Closed
atscott wants to merge 1 commit intoangular:mainangular/angular:mainfrom
atscott:testingharnessnullerroratscott/angular:testingharnessnullerrorCopy head branch name to clipboard
Closed
fix(router): RouterTestingHarness should throw if a component is ex…#52357atscott wants to merge 1 commit intoangular:mainangular/angular:mainfrom atscott:testingharnessnullerroratscott/angular:testingharnessnullerrorCopy head branch name to clipboard
RouterTestingHarness should throw if a component is ex…#52357atscott wants to merge 1 commit intoangular:mainangular/angular:mainfrom
atscott:testingharnessnullerroratscott/angular:testingharnessnullerrorCopy head branch name to clipboard
Conversation
…pected but navigation fails The `RouterTestingHarness` should throw an error if the call to `navigateByUrl` expects a component to be activated but the navigation failed. fixes angular#52344
AndrewKushnir
approved these changes
Oct 24, 2023
Contributor
|
This PR was merged into the repository by commit 0037c21. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…pected but navigation fails (angular#52357) The `RouterTestingHarness` should throw an error if the call to `navigateByUrl` expects a component to be activated but the navigation failed. fixes angular#52344 PR Close angular#52357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pected but navigation fails
The
RouterTestingHarnessshould throw an error if the call tonavigateByUrlexpects a component to be activated but the navigation failed.fixes #52344