fix(compiler): account for type-only imports in defer blocks#52343
Closed
crisbeto wants to merge 1 commit intoangular:mainangular/angular:mainfrom
crisbeto:defer-type-only-importscrisbeto/angular:defer-type-only-importsCopy head branch name to clipboard
Closed
fix(compiler): account for type-only imports in defer blocks#52343crisbeto wants to merge 1 commit intoangular:mainangular/angular:mainfrom crisbeto:defer-type-only-importscrisbeto/angular:defer-type-only-importsCopy head branch name to clipboard
crisbeto wants to merge 1 commit intoangular:mainangular/angular:mainfrom
crisbeto:defer-type-only-importscrisbeto/angular:defer-type-only-importsCopy head branch name to clipboard
Conversation
Fixes that `@defer` blocks didn't account for type-only imports which could cause the import to be considered as not deferrable.
AndrewKushnir
approved these changes
Oct 24, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@crisbeto thanks for the improvement! 👍
Contributor
|
This PR was merged into the repository by commit b6b5adc. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 24, 2023
Fixes that `@defer` blocks didn't account for type-only imports which could cause the import to be considered as not deferrable. PR Close #52343
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#52343) Fixes that `@defer` blocks didn't account for type-only imports which could cause the import to be considered as not deferrable. PR Close angular#52343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that
@deferblocks didn't account for type-only imports which could cause the import to be considered as not deferrable.