Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix(compiler): Support CSS Shiming for pseudo class functions with multiple arguments#49169

Closed
JeanMeche wants to merge 2 commits intoangular:mainangular/angular:mainfrom
JeanMeche:fix/49157JeanMeche/angular:fix/49157Copy head branch name to clipboard
Closed

fix(compiler): Support CSS Shiming for pseudo class functions with multiple arguments#49169
JeanMeche wants to merge 2 commits intoangular:mainangular/angular:mainfrom
JeanMeche:fix/49157JeanMeche/angular:fix/49157Copy head branch name to clipboard

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Feb 22, 2023

CSS functions like :has() or :is()can recieved multiple arguments separated by commas. This commit fixes the previously very partial support for it.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes: #49157 & #45686

@pullapprove pullapprove bot requested a review from alxhub February 22, 2023 23:33
@jessicajaniuk jessicajaniuk added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 2, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 2, 2023
@JeanMeche JeanMeche marked this pull request as draft May 1, 2023 14:26
@JeanMeche JeanMeche marked this pull request as ready for review August 4, 2023 21:49
@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: blocked labels Oct 11, 2023
@JeanMeche JeanMeche force-pushed the fix/49157 branch 2 times, most recently from f768b21 to a291dfa Compare October 12, 2023 16:18
@JeanMeche
Copy link
Member Author

@JeanMeche JeanMeche closed this Feb 29, 2024
@JeanMeche JeanMeche deleted the fix/49157 branch February 29, 2024 13:41
@JeanMeche JeanMeche restored the fix/49157 branch March 1, 2024 00:01
@JeanMeche JeanMeche reopened this Mar 1, 2024
@iRoyPeleg
Copy link

Hey @alxhub, any chance of this going in?
I would very much like to implement CSS Variables inside components, where I import the variables from an outside file, and thus I'd like their CSS specificity be 0, but :where(:host) doesnt work (output is :where()[nghost...]).
I'm hoping this PR will fix the issue, it's been active for quite a while now.

@iRoyPeleg
Copy link

Hey @JeanMeche!

Any chance to resolve the conflicts here?
We'd really like this issue fixed.

Thanks man!

JeanMeche added 2 commits May 29, 2024 10:52
…ents

CSS functions like `:has()` or `:is()`can recieved multiple arguments separated by commas. This commit fixes the previously very partial support for it.
In certain cases `:host` can land in an pseudo class functions. For example with tailwind we can write

```
:host {
  @apply dark:text-red-500;
}
```
gets converted to `:is(.dark :host)`.
This commit fixes the shiming to support it.

Fixes angular#45686
@JeanMeche JeanMeche closed this Sep 19, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS styles not applied if using multiple attribute selectors to style an element with the direct child selector

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.