Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix(router): Update createUrlTreeFromSnapshot to tolerate some ambiguity with empty paths#48734

Closed
atscott wants to merge 2 commits intoangular:mainangular/angular:mainfrom
atscott:createurltreedebugatscott/angular:createurltreedebugCopy head branch name to clipboard
Closed

fix(router): Update createUrlTreeFromSnapshot to tolerate some ambiguity with empty paths#48734
atscott wants to merge 2 commits intoangular:mainangular/angular:mainfrom
atscott:createurltreedebugatscott/angular:createurltreedebugCopy head branch name to clipboard

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Jan 13, 2023

See individual commits

The mocks in the tests make them hard to understand and they don't always test real router behavior
@atscott atscott added area: router target: patch This PR is targeted for the next patch release action: global presubmit The PR is in need of a google3 global presubmit labels Jan 13, 2023
@ngbot ngbot bot modified the milestone: Backlog Jan 13, 2023
@atscott atscott force-pushed the createurltreedebug branch 2 times, most recently from eaf0b74 to 117c70e Compare January 13, 2023 15:54
…utlets

The details of this commit are pretty thoroughly described in the tests
and code comments. In short, it is sometimes ambiguous where to apply commands in
a `SegmentGroup` tree that is created from an `ActivatedRoute` when
dealing with empty paths. This adjusts the strategy to tolerate more
ambiguity while still allowing developers to be explicit.

This is a fix-forward for b/265215141
@atscott atscott force-pushed the createurltreedebug branch from 117c70e to 13f63fa Compare January 13, 2023 16:18
@atscott
Copy link
Contributor Author

atscott commented Jan 13, 2023

TGP

@atscott atscott requested a review from AndrewKushnir January 13, 2023 20:09
@atscott atscott removed the action: global presubmit The PR is in need of a google3 global presubmit label Jan 13, 2023
@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 14, 2023
@atscott
Copy link
Contributor Author

atscott commented Jan 14, 2023

caretaker note: Please merge and sync on its own.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jan 17, 2023

FYI, adding the "blocked" label for now to avoid merging the PR until we get a confirmation from one of the internal teams.

@AndrewKushnir
Copy link
Contributor

FYI, got LGTMs from internal teams, moving forward with the merge.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 4dcab33.

AndrewKushnir pushed a commit that referenced this pull request Jan 18, 2023
The mocks in the tests make them hard to understand and they don't always test real router behavior

PR Close #48734
AndrewKushnir pushed a commit that referenced this pull request Jan 18, 2023
…utlets (#48734)

The details of this commit are pretty thoroughly described in the tests
and code comments. In short, it is sometimes ambiguous where to apply commands in
a `SegmentGroup` tree that is created from an `ActivatedRoute` when
dealing with empty paths. This adjusts the strategy to tolerate more
ambiguity while still allowing developers to be explicit.

This is a fix-forward for b/265215141

PR Close #48734
AndrewKushnir pushed a commit that referenced this pull request Jan 18, 2023
…utlets (#48734)

The details of this commit are pretty thoroughly described in the tests
and code comments. In short, it is sometimes ambiguous where to apply commands in
a `SegmentGroup` tree that is created from an `ActivatedRoute` when
dealing with empty paths. This adjusts the strategy to tolerate more
ambiguity while still allowing developers to be explicit.

This is a fix-forward for b/265215141

PR Close #48734
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jan 27, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.1/15.1.2) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.1/15.1.2) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.1/15.1.2) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.1/15.1.2) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.1/15.1.2) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.1/15.1.2) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.1/15.1.2) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.1/15.1.2) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v15.1.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1512-2023-01-25)

[Compare Source](angular/angular@15.1.1...15.1.2)

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [98ccb57117](angular/angular@98ccb57) | fix | handle css selectors with space after an escaped character. ([#&#8203;48558](angular/angular#48558)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [145f848a10](angular/angular@145f848) | fix | resolve deprecation warning ([#&#8203;48812](angular/angular#48812)) |

##### router

| Commit | Type | Description |
| -- | -- | -- |
| [a6b10f6e59](angular/angular@a6b10f6) | fix | 'createUrlTreeFromSnapshot' with empty paths and named outlets ([#&#8203;48734](angular/angular#48734)) |

#### Special Thanks

Alan Agius, AleksanderBodurri, Andrew Kushnir, Andrew Scott, Charles Lyding, Dylan Hunn, JoostK, Matthieu Riegler, Paul Gschwendtner, Payam Valadkhan, Virginia Dooley, Yann Thomas LE MOIGNE and dario-piotrowicz

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNC4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1751
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
)

The mocks in the tests make them hard to understand and they don't always test real router behavior

PR Close angular#48734
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
…utlets (angular#48734)

The details of this commit are pretty thoroughly described in the tests
and code comments. In short, it is sometimes ambiguous where to apply commands in
a `SegmentGroup` tree that is created from an `ActivatedRoute` when
dealing with empty paths. This adjusts the strategy to tolerate more
ambiguity while still allowing developers to be explicit.

This is a fix-forward for b/265215141

PR Close angular#48734
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.