Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

WIP - fix(ngcc): correctly handle UMD exports via element access expressions #43938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP - fix(ngcc): correctly handle UMD exports via element access expressions #43938

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 25, 2021

WIP

@google-cla google-cla bot added the cla: yes label Oct 25, 2021
@mary-poppins
Copy link

You can preview 07e5770 at https://pr43938-07e5770.ngbuilds.io/.

gkalpak added a commit to gkalpak/ngcc-validation that referenced this pull request Oct 25, 2021
@gkalpak
TEMP: Try PR angular/angular#43938
3b3ac4e
@gkalpak gkalpak mentioned this pull request Oct 25, 2021
Closed
@ngbot ngbot bot added this to the Backlog milestone Oct 25, 2021
@jessicajaniuk jessicajaniuk added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 25, 2021
@gkalpak gkalpak force-pushed the fix-ngcc-umd-exports branch from 07e5770 to 08ec120 Compare October 25, 2021 18:18
@mary-poppins
Copy link

You can preview 08ec120 at https://pr43938-08ec120.ngbuilds.io/.

@gkalpak gkalpak mentioned this pull request Nov 2, 2021
Closed
15 tasks
@gkalpak
Copy link
Member Author

gkalpak commented Nov 27, 2021

Closing, since this is not enough to address the whole problem.
@JoostK is working on a more adequate fix.

@gkalpak gkalpak closed this Nov 27, 2021
@gkalpak gkalpak deleted the fix-ngcc-umd-exports branch November 27, 2021 17:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area: compiler Issues related to `ngc`, Angular's template compiler cla: yes state: WIP
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@gkalpak @mary-poppins @jessicajaniuk
Morty Proxy This is a proxified and sanitized view of the page, visit original site.