Extended diagnostics integration #43107

danieltre23 · Aug 10, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Integrate extended template diagnostics with compiler and add extendedTemplateDiagnostics flag in the compiler options.

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

The compiler currently can't access the extended package.

Issue Number: #42966

What is the new behavior?

Added a new phase in the compiler that runs all template checks and generates extended template diagnostics when the extendedTemplateDiagnostics and strictTemplates flags are set.

Does this PR introduce a breaking change?

Yes
No

Other information

dgp1130 · Aug 10, 2021

I think you probably want to rebase this against master now that your previous PR has been merged. That should drop most of the extra commits here.

dgp1130

Looks good! Just a couple nits and a few questions for Andrew.

One other nit: The first commit message should probably have "refactor(compiler-cli): export getExtendedTemplateDiagnosticsForComponent and template checks" as its first line so it's more easily scanable when abbreviated to one line.

packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts

packages/compiler-cli/src/ngtsc/core/src/compiler.ts

packages/compiler-cli/src/ngtsc/transform/src/compilation.ts

packages/compiler-cli/test/ngtsc/extended_template_diagnostics_spec.ts

atscott

Looks great overall!

One thing about the feat commit in the middle: If we decide this is appropriately a feat, then we'll need to change the target to minor. If we want to merge to patch, that'll have to change to refactor because the tool won't allow feat commit in the patch branch.

packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts

packages/compiler-cli/src/ngtsc/core/src/compiler.ts

packages/compiler-cli/src/ngtsc/transform/src/api.ts

packages/compiler-cli/test/ngtsc/extended_template_diagnostics_spec.ts

packages/compiler-cli/src/ngtsc/core/src/compiler.ts

dgp1130

Looking good! Just a couple minor nits, but no major concerns here.

packages/compiler-cli/src/ngtsc/core/src/compiler.ts

packages/compiler-cli/src/ngtsc/transform/src/compilation.ts

This commit adds extended template diagnostics end-to-end tests, to make sure the diagnostics are generated correctly. Template checks are already tested with unit tests. Refs angular#42966

Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs angular#42966

Change the current way to run template checks to the `ExtendedTemplateChecker` instead of just the `getExtendedTemplateDiagnosticsForComponent` function. Refactored the tests that used the previous function to use the new class. Refs #42966 PR Close #43107

…late checks (#43107) This commit exports the implementation of `ExtendedTemplateChecker` to generate extended template diagnostics and all the template checks. Refs #42966 PR Close #43107

…#43107) This commit integrates extended template checks with the compiler, by adding another phase of diagnostics generation. This integration is under the `_extendedTemplateDiagnostics` flag. Refs #42966 PR Close #43107

#43107) This commit adds extended template diagnostics end-to-end tests, to make sure the diagnostics are generated correctly. Template checks are already tested with unit tests. Refs #42966 PR Close #43107

Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs #42966 PR Close #43107

…late checks (#43107) This commit exports the implementation of `ExtendedTemplateChecker` to generate extended template diagnostics and all the template checks. Refs #42966 PR Close #43107

…#43107) This commit integrates extended template checks with the compiler, by adding another phase of diagnostics generation. This integration is under the `_extendedTemplateDiagnostics` flag. Refs #42966 PR Close #43107

#43107) This commit adds extended template diagnostics end-to-end tests, to make sure the diagnostics are generated correctly. Template checks are already tested with unit tests. Refs #42966 PR Close #43107

Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs #42966 PR Close #43107

angular-automatic-lock-bot · Sep 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

danieltre23 requested review from atscott and dgp1130 August 10, 2021 20:57

google-cla bot added the cla: yes label Aug 10, 2021

danieltre23 force-pushed the extended-diagnostics-integration branch 3 times, most recently from 8775483 to 8174a07 Compare August 11, 2021 17:56

danieltre23 added the target: patch This PR is targeted for the next patch release label Aug 11, 2021

danieltre23 marked this pull request as ready for review August 11, 2021 21:43

dgp1130 requested changes Aug 11, 2021

View reviewed changes

danieltre23 force-pushed the extended-diagnostics-integration branch from 8174a07 to 0ca47a5 Compare August 12, 2021 18:03

atscott requested changes Aug 12, 2021

View reviewed changes

danieltre23 force-pushed the extended-diagnostics-integration branch from 0ca47a5 to 3a72d17 Compare August 12, 2021 21:02

danieltre23 requested review from dgp1130 and atscott August 12, 2021 21:05

danieltre23 force-pushed the extended-diagnostics-integration branch from 3a72d17 to 164c563 Compare August 12, 2021 21:08

danieltre23 mentioned this pull request Aug 12, 2021

Extended language service #43134

Closed

14 tasks

AndrewKushnir added area: compiler Issues related to `ngc`, Angular's template compiler area: language-service Issues related to Angular's VS Code language service labels Aug 12, 2021

ngbot bot added this to the Backlog milestone Aug 12, 2021

dgp1130 approved these changes Aug 13, 2021

View reviewed changes

packages/compiler-cli/src/ngtsc/core/src/compiler.ts Outdated Show resolved Hide resolved

packages/compiler-cli/src/ngtsc/transform/src/compilation.ts Outdated Show resolved Hide resolved

danieltre23 force-pushed the extended-diagnostics-integration branch 2 times, most recently from aef54bd to 9242cf8 Compare August 13, 2021 15:42

atscott approved these changes Aug 16, 2021

View reviewed changes

pullapprove bot requested review from IgorMinar, jelbourn, jessicajaniuk and petebacondarwin August 16, 2021 18:02

danieltre23 force-pushed the extended-diagnostics-integration branch from 9242cf8 to 3c2150b Compare August 16, 2021 22:02

danieltre23 removed the request for review from petebacondarwin August 16, 2021 22:02

danieltre23 added 2 commits August 18, 2021 19:28

test(compiler-cli): add extended template diagnostics end-to-end tests

67cf0cd

This commit adds extended template diagnostics end-to-end tests, to make sure the diagnostics are generated correctly. Template checks are already tested with unit tests. Refs angular#42966

test(language-service): add extended diagnostics test

f1df924

Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs angular#42966

danieltre23 force-pushed the extended-diagnostics-integration branch from a83684e to f1df924 Compare August 18, 2021 19:29

danieltre23 requested a review from alxhub August 18, 2021 19:31

alxhub approved these changes Aug 18, 2021

View reviewed changes

danieltre23 mentioned this pull request Aug 18, 2021

Extended template checks #42984

Closed

14 tasks

danieltre23 added the action: merge The PR is ready for merge by the caretaker label Aug 19, 2021

alxhub pushed a commit that referenced this pull request Aug 19, 2021

test(language-service): add extended diagnostics test (#43107)

cb8e51f

Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs #42966 PR Close #43107

alxhub closed this in 3932480 Aug 19, 2021

alxhub pushed a commit that referenced this pull request Aug 19, 2021

test(language-service): add extended diagnostics test (#43107)

c389052

Add a test in the langauge-service to make sure the extended template diagnostics are being correctly generated. Refs #42966 PR Close #43107

danieltre23 mentioned this pull request Aug 23, 2021

Extended refactor #43232

Closed

14 tasks

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extended diagnostics integration #43107

Extended diagnostics integration #43107

Uh oh!

danieltre23 commented Aug 10, 2021 •

edited

Loading

Uh oh!

dgp1130 commented Aug 10, 2021

Uh oh!

dgp1130 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atscott left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgp1130 left a comment

Uh oh!

Uh oh!

Uh oh!

angular-automatic-lock-bot bot commented Sep 19, 2021

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

Extended diagnostics integration #43107

Extended diagnostics integration #43107

Uh oh!

Conversation

danieltre23 commented Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

dgp1130 commented Aug 10, 2021

Uh oh!

dgp1130 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgp1130 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

angular-automatic-lock-bot bot commented Sep 19, 2021

Uh oh!

Uh oh!

danieltre23 commented Aug 10, 2021 •

edited

Loading