angular · arturovt · Dec 3, 2020 · Dec 4, 2020 · Dec 4, 2020 · Dec 4, 2020
diff --git a/goldens/size-tracking/aio-payloads.json b/goldens/size-tracking/aio-payloads.json
@@ -12,7 +12,7 @@
    "master": {
      "uncompressed": {
        "runtime-es2015": 3033,
-        "main-es2015": 447975,
+        "main-es2015": 447349,
        "polyfills-es2015": 52493
      }
    }

diff --git a/goldens/size-tracking/integration-payloads.json b/goldens/size-tracking/integration-payloads.json
@@ -3,7 +3,7 @@
    "master": {
      "uncompressed": {
        "runtime-es2015": 1485,
-        "main-es2015": 141516,
+        "main-es2015": 140921,
        "polyfills-es2015": 36964
      }
    }

diff --git a/packages/animations/browser/src/render/css_keyframes/css_keyframes_driver.ts b/packages/animations/browser/src/render/css_keyframes/css_keyframes_driver.ts
@@ -21,7 +21,6 @@ const TAB_SPACE = ' ';
 export class CssKeyframesDriver implements AnimationDriver {
  private _count = 0;
  private readonly _head: any = document.querySelector('head');
-  private _warningIssued = false;

  validateStyleProperty(prop: string): boolean {
    return validateStyleProperty(prop);
@@ -79,8 +78,8 @@ export class CssKeyframesDriver implements AnimationDriver {
  animate(
      element: any, keyframes: ɵStyleData[], duration: number, delay: number, easing: string,
      previousPlayers: AnimationPlayer[] = [], scrubberAccessRequested?: boolean): AnimationPlayer {
-    if (scrubberAccessRequested) {
-      this._notifyFaultyScrubber();
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) && scrubberAccessRequested) {
+      notifyFaultyScrubber();
    }

    const previousCssKeyframePlayers = <CssKeyframesPlayer[]>previousPlayers.filter(
@@ -117,15 +116,6 @@ export class CssKeyframesDriver implements AnimationDriver {
    player.onDestroy(() => removeElement(kfElm));
    return player;
  }
-
-  private _notifyFaultyScrubber() {
-    if (!this._warningIssued) {
-      console.warn(
-          '@angular/animations: please load the web-animations.js polyfill to allow programmatic access...\n',
-          '  visit https://bit.ly/IWukam to learn more about using the web-animation-js polyfill.');
-      this._warningIssued = true;
-    }
-  }
 }

 function flattenKeyframesIntoStyles(keyframes: null|{[key: string]: any}|
@@ -146,3 +136,12 @@ function flattenKeyframesIntoStyles(keyframes: null|{[key: string]: any}|
 function removeElement(node: any) {
  node.parentNode.removeChild(node);
 }
+
+let warningIssued = false;
+function notifyFaultyScrubber(): void {
+  if (warningIssued) return;
+  console.warn(
+      '@angular/animations: please load the web-animations.js polyfill to allow programmatic access...\n',
+      '  visit https://bit.ly/IWukam to learn more about using the web-animation-js polyfill.');
+  warningIssued = true;
+}
diff --git a/packages/common/src/directives/ng_for_of.ts b/packages/common/src/directives/ng_for_of.ts
@@ -6,7 +6,7 @@
 * found in the LICENSE file at https://angular.io/license
 */

-import {Directive, DoCheck, EmbeddedViewRef, Input, isDevMode, IterableChangeRecord, IterableChanges, IterableDiffer, IterableDiffers, NgIterable, TemplateRef, TrackByFunction, ViewContainerRef} from '@angular/core';
+import {Directive, DoCheck, EmbeddedViewRef, Input, IterableChangeRecord, IterableChanges, IterableDiffer, IterableDiffers, NgIterable, TemplateRef, TrackByFunction, ViewContainerRef} from '@angular/core';

 /**
 * @publicApi
@@ -159,7 +159,7 @@ export class NgForOf<T, U extends NgIterable<T> = NgIterable<T>> implements DoCh
   */
  @Input()
  set ngForTrackBy(fn: TrackByFunction<T>) {
-    if (isDevMode() && fn != null && typeof fn !== 'function') {
+    if ((typeof ngDevMode === 'undefined' || ngDevMode) && fn != null && typeof fn !== 'function') {
      // TODO(vicb): use a log service once there is a public one available
      if (<any>console && <any>console.warn) {
        console.warn(

diff --git a/packages/common/src/pipes/number_pipe.ts b/packages/common/src/pipes/number_pipe.ts
@@ -241,7 +241,7 @@ export class CurrencyPipe implements PipeTransform {
    locale = locale || this._locale;

    if (typeof display === 'boolean') {
-      if (<any>console && <any>console.warn) {
+      if ((typeof ngDevMode === 'undefined' || ngDevMode) && <any>console && <any>console.warn) {
        console.warn(
            `Warning: the currency pipe has been changed in Angular v5. The symbolDisplay option (third parameter) is now a string instead of a boolean. The accepted values are "code", "symbol" or "symbol-narrow".`);
      }

diff --git a/packages/core/src/application_ref.ts b/packages/core/src/application_ref.ts
@@ -597,7 +597,6 @@ export class ApplicationRef {
  private _bootstrapListeners: ((compRef: ComponentRef<any>) => void)[] = [];
  private _views: InternalViewRef[] = [];
  private _runningTick: boolean = false;
-  private _enforceNoNewChanges: boolean = false;
  private _stable = true;
  private _onMicrotaskEmptySubscription: Subscription;

@@ -626,8 +625,6 @@ export class ApplicationRef {
      private _exceptionHandler: ErrorHandler,
      private _componentFactoryResolver: ComponentFactoryResolver,
      private _initStatus: ApplicationInitStatus) {
-    this._enforceNoNewChanges = isDevMode();
-
    this._onMicrotaskEmptySubscription = this._zone.onMicrotaskEmpty.subscribe({
      next: () => {
        this._zone.run(() => {
@@ -764,7 +761,9 @@ export class ApplicationRef {
      for (let view of this._views) {
        view.detectChanges();
      }
-      if (this._enforceNoNewChanges) {
+      // Note that we have still left the `isDevMode()` condition in order to avoid
+      // creating a breaking change for projects that still use the View Engine.
+      if ((typeof ngDevMode === 'undefined' || ngDevMode) && isDevMode()) {
        for (let view of this._views) {
          view.checkNoChanges();
        }

diff --git a/packages/forms/src/directives/reactive_directives/form_control_directive.ts b/packages/forms/src/directives/reactive_directives/form_control_directive.ts
@@ -125,7 +125,9 @@ export class FormControlDirective extends NgControl implements OnChanges {
      this.form.updateValueAndValidity({emitEvent: false});
    }
    if (isPropertyUpdated(changes, this.viewModel)) {
-      _ngModelWarning('formControl', FormControlDirective, this, this._ngModelWarningConfig);
+      if (typeof ngDevMode === 'undefined' || ngDevMode) {
+        _ngModelWarning('formControl', FormControlDirective, this, this._ngModelWarningConfig);
+      }
      this.form.setValue(this.model);
      this.viewModel = this.model;
    }

diff --git a/packages/forms/src/directives/reactive_directives/form_control_name.ts b/packages/forms/src/directives/reactive_directives/form_control_name.ts
@@ -145,7 +145,9 @@ export class FormControlName extends NgControl implements OnChanges, OnDestroy {
  ngOnChanges(changes: SimpleChanges) {
    if (!this._added) this._setUpControl();
    if (isPropertyUpdated(changes, this.viewModel)) {
-      _ngModelWarning('formControlName', FormControlName, this, this._ngModelWarningConfig);
+      if (typeof ngDevMode === 'undefined' || ngDevMode) {
+        _ngModelWarning('formControlName', FormControlName, this, this._ngModelWarningConfig);
+      }
      this.viewModel = this.model;
      this.formDirective.updateModel(this, this.model);
    }

diff --git a/packages/forms/src/directives/shared.ts b/packages/forms/src/directives/shared.ts
@@ -6,8 +6,6 @@
 * found in the LICENSE file at https://angular.io/license
 */

-import {isDevMode} from '@angular/core';
-
 import {AbstractControl, FormArray, FormControl, FormGroup} from '../model';
 import {getControlAsyncValidators, getControlValidators, mergeValidators} from '../validators';

@@ -324,13 +322,11 @@ export function removeListItem<T>(list: T[], el: T): void {
 export function _ngModelWarning(
    name: string, type: {_ngModelWarningSentOnce: boolean},
    instance: {_ngModelWarningSent: boolean}, warningConfig: string|null) {
-  if (!isDevMode() || warningConfig === 'never') return;
+  if (warningConfig === 'never') return;

  if (((warningConfig === null || warningConfig === 'once') && !type._ngModelWarningSentOnce) ||
      (warningConfig === 'always' && !instance._ngModelWarningSent)) {
-    if (typeof ngDevMode === 'undefined' || ngDevMode) {
-      ReactiveErrors.ngModelWarning(name);
-    }
+    ReactiveErrors.ngModelWarning(name);
    type._ngModelWarningSentOnce = true;
    instance._ngModelWarningSent = true;
  }