docs(lifecycle-hooks): updates directive event hooks real capabilities #16654

Drumarcco · May 9, 2017

Minor documentation update to include event hooks that were assumed to only work on components.

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Other... Please describe: Documentation regarding directives event hooks.

What is the current behavior? (You can also link to an open issue here)
The docs assume some event hooks don't work on directives when they actually do.

What is the new behavior?
The docs are updated to match directives' real capabilities.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

Other information:
It's the same as this PR angular/angular.io#2816 but applied on angular/angular

tbosch · May 11, 2017

aio/content/guide/lifecycle-hooks.md

Respond the first time Angular has checked the content children of a directive/component.

tbosch · May 11, 2017

aio/content/guide/lifecycle-hooks.md

Respond every time Angular has checked the content children of a directive/component.

tbosch · May 11, 2017

aio/content/guide/lifecycle-hooks.md

Respond the first time Angular has checked the component's view / the view that a directive is in.

tbosch · May 11, 2017

aio/content/guide/lifecycle-hooks.md

Respond every time Angular has checked the component's view / the view that a directive is in.

Drumarcco · May 11, 2017

@tbosch PR updated 😄

googlebot · Jul 26, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · Jul 26, 2017

CLAs look good, thanks!

sandangel · Nov 7, 2017

any plan to merge this?

gkalpak · Nov 10, 2017

Hm...not sure what happened here. Looks like it should have been merged a while ago.
@Drumarcco, can you please rebase on latest master?

Drumarcco · Nov 10, 2017

Sure!

…

On Fri, Nov 10, 2017 at 4:11 AM George Kalpakas ***@***.***> wrote: Hm...not sure what happened here. Looks like it should have been merged a while ago. @Drumarcco <https://github.com/drumarcco>, can you please rebase on latest master? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16654 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIuU0PRGK0Po_hkzsfQKt4Qw_EDXu5c6ks5s1C95gaJpZM4NVmcI> .

Minor documentation update to include event hooks that were assumed to only work on components. Closes angular#10221

Drumarcco · Nov 23, 2017

PR Updated, CI failed for some reason 🤔

Minor documentation update to include event hooks that were assumed to only work on components. Closes #10221 PR Close #16654

angular-automatic-lock-bot · Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label May 9, 2017

Drumarcco force-pushed the docs-directive-lifecycle-hooks branch from 8427868 to 28981df Compare May 9, 2017 17:02

gkalpak mentioned this pull request May 9, 2017

docs(lifecycle-hooks): update event hooks to match directives capabilities angular/angular.io#2816

Open

gkalpak added comp: aio labels May 9, 2017

tbosch reviewed May 11, 2017

View reviewed changes

aio/content/guide/lifecycle-hooks.md Outdated

Copy link

Contributor

tbosch May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respond every time Angular has checked the content children of a directive/component.

tbosch reviewed May 11, 2017

View reviewed changes

Drumarcco force-pushed the docs-directive-lifecycle-hooks branch 2 times, most recently from b1a8775 to 682877f Compare May 11, 2017 18:52

tbosch approved these changes May 12, 2017

View reviewed changes

tbosch added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels May 12, 2017

wardbell added area: core Issues related to the framework runtime and removed comp: aio labels Jun 21, 2017

mhevery force-pushed the master branch from 08b36cb to 5d4b36f Compare July 20, 2017 21:48

googlebot added cla: no and removed cla: yes labels Jul 26, 2017

mhevery force-pushed the docs-directive-lifecycle-hooks branch from afb0b92 to 682877f Compare July 26, 2017 19:52

googlebot added cla: yes and removed cla: no labels Jul 26, 2017

gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Nov 10, 2017

docs(aio): updates directive event hooks real capabilities

8c72579

Minor documentation update to include event hooks that were assumed to only work on components. Closes angular#10221

Drumarcco force-pushed the docs-directive-lifecycle-hooks branch from 682877f to 8c72579 Compare November 23, 2017 07:26

kapunahelewong approved these changes Feb 21, 2018

View reviewed changes

StephenFluin approved these changes Feb 21, 2018

View reviewed changes

kara added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 21, 2018

vicb closed this in b42921b Feb 21, 2018

vicb pushed a commit that referenced this pull request Feb 21, 2018

docs(aio): updates directive event hooks real capabilities (#16654)

612cfec

Minor documentation update to include event hooks that were assumed to only work on components. Closes #10221 PR Close #16654

jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Dec 13, 2018

ngbot bot added this to the needsTriage milestone Dec 13, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Search code, repositories, users, issues, pull requests...

docs(lifecycle-hooks): updates directive event hooks real capabilities #16654

docs(lifecycle-hooks): updates directive event hooks real capabilities #16654

Uh oh!

Conversation

Drumarcco commented May 9, 2017

Uh oh!

tbosch May 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbosch May 11, 2017

Choose a reason for hiding this comment

Uh oh!

tbosch May 11, 2017

Choose a reason for hiding this comment

Uh oh!

tbosch May 11, 2017

Choose a reason for hiding this comment

Uh oh!

Drumarcco commented May 11, 2017

Uh oh!

googlebot commented Jul 26, 2017

Uh oh!

googlebot commented Jul 26, 2017

Uh oh!

sandangel commented Nov 7, 2017

Uh oh!

gkalpak commented Nov 10, 2017

Uh oh!

Drumarcco commented Nov 10, 2017 via email

Uh oh!

Drumarcco commented Nov 23, 2017

Uh oh!

angular-automatic-lock-bot bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tbosch May 11, 2017 •

edited

Loading