Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ngOnDestroy not called for injectables created via factory providers provided at component level #28738

Copy link
Copy link
Open
@llorenspujol

Description

@llorenspujol
Issue body actions

🐞 bug report

Affected Package

@angular/core

Is this a regression?

Don't know

Description

ngOnDestroy is not called for Services provided via factory function into component level.

🔬 Minimal Reproduction

I forked the Angular repo and created a Merge Request including 2 tests that both should pass. Of course, one test don't pass, that is the ones that we provide the service using the factory function.

EDIT: I also have added the code to make the tests pass, although I am not in context at all, an maybe I am missing something in the path

Here is the MR: #28737

🌍 Your Environment

Angular Version: 8.0.0-beta.3

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.