From 8c9ea5acfe0c2901e4eaa8702118aaf070ed1591 Mon Sep 17 00:00:00 2001 From: WonderCsabo Date: Sun, 31 Aug 2014 19:53:51 +0200 Subject: [PATCH] Fix validation of @SupposeXXX The validator did not checked the final modifier of the annotated method. --- .../androidannotations/handler/SupposeThreadHandler.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/handler/SupposeThreadHandler.java b/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/handler/SupposeThreadHandler.java index 9945d1e4e3..acab39f709 100644 --- a/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/handler/SupposeThreadHandler.java +++ b/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/handler/SupposeThreadHandler.java @@ -15,13 +15,13 @@ */ package org.androidannotations.handler; +import javax.annotation.processing.ProcessingEnvironment; +import javax.lang.model.element.Element; + import org.androidannotations.holder.EComponentHolder; import org.androidannotations.model.AnnotationElements; import org.androidannotations.process.IsValid; -import javax.annotation.processing.ProcessingEnvironment; -import javax.lang.model.element.Element; - public abstract class SupposeThreadHandler extends BaseAnnotationHandler { public SupposeThreadHandler(Class targetClass, ProcessingEnvironment processingEnvironment) { @@ -32,6 +32,7 @@ public SupposeThreadHandler(Class targetClass, ProcessingEnvironment processi protected void validate(Element element, AnnotationElements validatedElements, IsValid valid) { validatorHelper.enclosingElementHasEnhancedComponentAnnotation(element, validatedElements, valid); validatorHelper.isNotPrivate(element, valid); + validatorHelper.isNotFinal(element, valid); } }