Preserve stellar properties when restarting with SeBa #1105
Conversation
|
We checked this together, and it seems to be the right thing to do to realize restarts with evolved stars. |
|
Then you don't want to close it but to merge it, I guess? |
|
@rieder Yes, I think Simon was trying to merge it -- we were discussing it live during the Torch meeting. The corresponding pull request in the SeBa repo was just merged. |
|
the download.py still needs to be updated to the new SeBa version. |
|
@rieder I can do that now and submit a new pull request, or would you prefer to re-open this one? |
|
@rieder @spzwart I have prepared a pull request with the changed SeBa version, but there is an issue. Although the SeBa worker compiles without issues with the changes from the last pull request, any SeBa commit from 382b5904609b1a44577f1d652c2eba34f9192616 on includes changes that prevent the worker from compiling. How would you like to proceed? |
This fix ensures that the stellar properties (in particular the
relative_mass) are preserved when restarting with SeBa. The other properties (such as the radius, luminosity, and temperature) are also correctly calculated during the stellar evolution step. The changes presented in this pull request also require the change proposed in commit 01dcff8da08833622a2b52c507f2275ea4f3117e to be implemented in the SeBa repository.