Updates/orbital elements #1047
Merged
Updates/orbital elements #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LourensVeen
reviewed
Apr 24, 2024
Member
LourensVeen
left a comment
There was a problem hiding this comment.
Looks good, but I have a few questions. Let's discuss.
|
|
||
| def initialize(self, radii, densities, core_radius = None): | ||
| self.sort_density_and_radius(densities*1.0, radii*1.0, core_radius = core_radius) | ||
| self.four_thirds_pi = numpy.pi * 4.0 / 3.0 |
Member
There was a problem hiding this comment.
This could (should, but not necessarily in this PR) be a module-level constant rather than a member variable.
| return (self.enclosed_mass[index] + self.four_thirds_pi * | ||
| self.densities[index] * (radius**3 - self.radii_cubed[index])) | ||
|
|
||
| return self.enclosed_mass[index] + self.four_thirds_pi * self.densities[ |
Member
There was a problem hiding this comment.
Well, that's not an improvement, but if this is what black makes of it then it is what it is...
| [tool.setuptools_scm] | ||
| write_to = "src/amuse/version.py" | ||
|
|
||
| [flake8] |
Member
There was a problem hiding this comment.
The black documentation says it uses [tool.black]? Or are we using flake8 here? I'm confused.
|
|
||
| from optparse import OptionParser | ||
|
|
||
| # Should probably use an absolute import here (support.config), but |
Member
There was a problem hiding this comment.
This will probably get fixed with the new build system, as we're not running amusifier anymore as part of the installation process. But that change belongs with that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to orbital_elements.py, allow orbital elements to be returned as a dictionary for clarity