Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

New commons, ESM-compatible Cypress integration #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 19, 2024
Merged

New commons, ESM-compatible Cypress integration #905

merged 11 commits into from
Mar 19, 2024

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Mar 11, 2024

Context

new version of #897

Checklist

@epszaw epszaw added type:improvement Improvement or request theme:api Javascript API related issue labels Mar 11, 2024
@github-actions github-actions bot removed the type:improvement Improvement or request label Mar 11, 2024
@epszaw epszaw changed the title New commons New commons, ESM-compatible Cypress integration Mar 14, 2024
@epszaw epszaw added type:improvement Improvement or request theme:cypress labels Mar 14, 2024
make cypress integration compatible with both cjs and esm modules
move some common utilities from node to framework directory
change commons build workflow
use absolute imports instead of relative ones in cypress tests
use new commons for cypress integration
@github-actions github-actions bot added theme:hermione theme:jest Jest related issue theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:vitest labels Mar 14, 2024
@epszaw epszaw marked this pull request as ready for review March 14, 2024 12:07
@epszaw epszaw requested review from baev and delatrie March 14, 2024 12:07
@epszaw epszaw mentioned this pull request Mar 14, 2024
2 tasks
@epszaw epszaw force-pushed the new-commons branch 2 times, most recently from 99362b5 to ab980cf Compare March 19, 2024 10:13
Copy link
Contributor

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the PR, looks good, nice modernization

@epszaw epszaw force-pushed the new-commons branch 2 times, most recently from af2e146 to 2be1512 Compare March 19, 2024 10:54
@baev baev merged commit 6ce0961 into main Mar 19, 2024
@baev baev deleted the new-commons branch March 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:api Javascript API related issue theme:build theme:cucumberjs CucumberJS related issue theme:cypress theme:hermione theme:jasmine Jasmine related issue theme:jest Jest related issue theme:playwright theme:vitest type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.