Stop printing message when doing a context shutdown #374
Conversation
|
Good catch, thanks! |
|
Probably this was the reason :) https://github.com/allegro/bigcache/actions/runs/6145556141/job/16673759956?pr=374#step:5:25 |
|
I honestly have no idea why it would cause that. |
|
AFAIR it's because during a test run If you're curious to fix it than try to replace this context with Line 63 in 157556c And if you're not curious (which is fine too) I will take a look later today (leaving PR open for some time). Thanks. |
|
|
||
| if config.CleanWindow > 0 { | ||
| go func() { | ||
| logger := newLogger(config.Logger) |
There was a problem hiding this comment.
This will solve the data race
| go func() { | |
| logger := newLogger(config.Logger) | |
| logger := newLogger(config.Logger) | |
| go func() { |
There was a problem hiding this comment.
Nice! anyway, replacing ctx is also a good thing for the future.
|
@rubenv Ping |
Uses the configured logger instead.