Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: jagged white edge around the logo #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2020
Merged

fix: jagged white edge around the logo #421

merged 4 commits into from
Jul 16, 2020

Conversation

MicaelJarniac
Copy link
Contributor

What:

Fixes #420

Why:

To make the logo displayed on the README.md more clean and consistent across different backgrounds, not just white.

How:

By replacing the reference to docs/assets/logo-full-transparent.png with the same SVG logo used on allcontributors.org https://d33wubrfki0l68.cloudfront.net/02a655fd7b0c5dae117b57bfde67f8850bb23226/e2f0c/img/logo.svg

Checklist:

  • Documentation N/A
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

This is one way of fixing the issue reported in issue #420, but as mentioned in that issue, this might not be the cleaner, most desirable, way of going about it.

@MicaelJarniac
Fix for the jagged white edge around the logo
c25716a 
This is one way of fixing the issue reported in issue #420, but as mentioned in that issue, this might not be the cleaner, most desirable, way of going about it.

The image is now the same used in allcontributors.org

Fix #420
@MicaelJarniac MicaelJarniac mentioned this pull request Jul 14, 2020
Closed
Berkmann18
Berkmann18 requested changes Jul 15, 2020
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think switching to an SVG image is indeed a good idea, however it should be part of the repo itself so it doesn't rely on an external source.

@Berkmann18 Berkmann18 added the enhancement New feature or request label Jul 15, 2020
@MicaelJarniac
Copy link
Contributor Author

I think switching to an SVG image is indeed a good idea, however it should be part of the repo itself so it doesn't rely on an external source.

Done! It's now a file stored locally on the repo, alongside the logo-full-transparent.png, called logo-full.svg (I omitted the transparent at the end because I believe it being an SVG file implies that, in a way.

The previous file is still there.

And the reference to it on the README.md has been replaced to the new local SVG logo.

@MicaelJarniac MicaelJarniac changed the title Fix for the jagged white edge around the logo fix: jagged white edge around the logo Jul 15, 2020
@MicaelJarniac MicaelJarniac requested a review from Berkmann18 July 15, 2020 20:02
Berkmann18
Berkmann18 reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. I've got some questions surrounding the performance side of things.

  1. Do you think it would be possible to remove the redundant layer(s)?
  2. Have you optimised the SVG?

@MicaelJarniac
Copy link
Contributor Author

Looking good so far. I've got some questions surrounding the performance side of things.

  1. Do you think it would be possible to remove the redundant layer(s)?
  2. Have you optimised the SVG?

I have absolutely no idea. I've never dealt with this kind of file before. But it's the one used for the logo on https://allcontributors.org.

So I think it's either fine to use it here as well, or it should also be updated on the website.

But again, I've never played with this kind of file, so I really don't know for sure.

@Berkmann18
Copy link
Member

It's fine, SVG isn't my forté either, it's mainly things that came to mind when I contributed to simple-icons which recommends contributors to compress SVGs using SVGO or SVGOMG and removing code like <g> and </g> which AFAIK don't change anything as far as the rendering and output goes,

@MicaelJarniac
Copy link
Contributor Author

MicaelJarniac commented Jul 16, 2020 •
edited
Loading

It's fine, SVG isn't my forté either, it's mainly things that came to mind when I contributed to simple-icons which recommends contributors to compress SVGs using SVGO or SVGOMG and removing code like <g> and </g> which AFAIK don't change anything as far as the rendering and output goes,

I've just run it against SVGOMG, and removed the <g> and </g> tags, but it dropped only from 6.99k to 6.69k, which I think isn't a lot.

I could get it to 5.44k, but that'd slightly move things around, and I'd rather not. Here's a GIF showing that (watch closely):

GIF

The 6.69k version seems to have no quality loss.

I'll update my branch with it.

@MicaelJarniac
Updated SVG logo with slightly lighter one
ebb71f2 
Previous one was **6.99k**, new one is **6.69k**, no perceptible quality loss
@MicaelJarniac MicaelJarniac requested a review from Berkmann18 July 16, 2020 16:40
Berkmann18
Berkmann18 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
@all-contributors please add @MicaelJarniac for bug

@Berkmann18 Berkmann18 merged commit 7643f40 into all-contributors:master Jul 16, 2020
@Berkmann18
Copy link
Member

@all-contributors Please add @MicaelJarniac for bug

@allcontributors allcontributors bot mentioned this pull request Jul 16, 2020
Merged
@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @MicaelJarniac! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 2.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MicaelJarniac MicaelJarniac deleted the patch-1 branch July 16, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logo has jagged white edge

3 participants

@MicaelJarniac @Berkmann18 @all-contributors-release-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.