Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

v9 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexewerlof wants to merge 100 commits into
base: master
Choose a base branch
Loading
from
Open

v9 #84

alexewerlof wants to merge 100 commits into from

Conversation

@alexewerlof
Copy link
Owner

@alexewerlof alexewerlof commented Aug 16, 2020 •
edited
Loading

Summary

Drop the Renderer class in favour of pure functions and transformations.
Some more work is needed on the documentation.
close #79: This PR makes #79 unnecessary

Checklist

  • All new functionality is tested
  • Any documentation that will be affected is updated

@alexewerlof
rename get() to getPath()
059a802
@alexewerlof
separate testing long template and long path and add a couple more pe…
b41303a 
…rf tests
@alexewerlof
now tokenization is used for path and parsing is used for templates
c2df168
@alexewerlof
update the security file
d0c2e33
@alexewerlof
update the compile docs
61aaabf
@alexewerlof
add the resolve function
5ba208d
@alexewerlof
small update to the tokenize()
b740e1e
@alexewerlof
fix a typo in the README
851e7de
@alexewerlof
improve Ref documentation
4087fcb
@alexewerlof
ignore cpu profile files
281ec53
@alexewerlof
create a cpu profile file for the perf script
4af9e1c
@alexewerlof
add transform, renderFn and renderFnAsync
09666ae 
break the long parse function to two.
Updated the examples with the new syntax
@alexewerlof
Rename get* methods according to #83
490d6a9
@alexewerlof
refactor params of pathGet() and refGet() to close #83
7c55886
@alexewerlof
the validatePath option is removed
bb8f578
@alexewerlof
improve the documentation
aacb771
@alexewerlof
rename vars to subs (in parsedTemplate)
3264a85
@alexewerlof
move the default values to a separate file. Fix #85
41fa81c
@alexewerlof
use the defaults to fill up the playground input fields
ca7f323
@alexewerlof
update the playground
8a8fab9
@alexewerlof
add a missing check
de68f61
@alexewerlof
render no more accepts ParsedTemplate<string>
6eef39c
@alexewerlof
add a "realistic" test
25f4e36
@alexewerlof
slight improvement to the perf test script
577c312
@alexewerlof
fixed a typo
aab8a2e
@alexewerlof
pass the options to the playground render
16075c1
@alexewerlof
adjust eslint config for switch..case indentation
0a62aa1
@alexewerlof
tokenizePath() is now called pathToRef()
6896fce
@alexewerlof
parseTemplate() is now called parse()
41932e2
@alexewerlof
distinguish between CompiledTemplate and ParsedTemplate
43d20e6
@alexewerlof
fixed a typo in comment
f754845
@alexewerlof
we now emit es6 (extending Map for Cache needs that)
c9628a7
@alexewerlof
improve the documentation for CACHE_SIZE
f1c4594
@alexewerlof
shorten the Cache implementation by extending Map
9dedf07
@alexewerlof
couple empty lines
6ab7cd5
@alexewerlof
small code shrink
843912b
@alexewerlof
use an internal function fot getting the parsed template
8f30d67
@alexewerlof
create type errors in a function with consistent msg
956b1b4
@alexewerlof
more errors are now created consistently
e4128fd
@alexewerlof
shorter name for error factories
26ad3d4
@alexewerlof
shorter syntax for making error objects
1455c3f
@alexewerlof
we always check if a number is positive
255ba5f
@alexewerlof
we don't need isInt
94995d0
@alexewerlof
we don't need ResolveFnAsync and ResolveFn
653465f
@alexewerlof
we don't need isFn
7e5c88c
@alexewerlof
shorter isArr definition
c5dcdc7
@alexewerlof
we don't need isOwnProp
7f17533
@alexewerlof
remove an unused const
f166186
@alexewerlof
remove unneeded code
e6d8907
@alexewerlof
improve error messages
a745610
@alexewerlof
tiny internal refactor
e54a278
@alexewerlof
update an inaccurate comment
806a1a6
@alexewerlof
swap a condition to make the code more readable
d1109af
@alexewerlof
mark some internal functions with @internal
0017e55
@alexewerlof
ignore the TODO file in git
df53f4b
@alexewerlof
make the playground link more dominant
1ece5bb
@tmikaeld
Copy link

tmikaeld commented Feb 15, 2022

@userpixel Would love to see V9 come to fruition, this is by far the best made CSP template rendering that exist!

@tmikaeld
Copy link

tmikaeld commented Feb 15, 2022

Is this branch complete for V9? Can we use it as is?

@alexewerlof
Copy link
Owner Author

alexewerlof commented Feb 16, 2022

@tmikaeld it was a while ago I worked on this branch. Don't have time to go through it and prepare it for release.
You can fork it and use it as is or you can file issues for what exactly you're missing that is blocked by this branch. I can't make a promise that v9 will be available soon because I've moved on career-wise.

@tmikaeld
Copy link

tmikaeld commented Feb 16, 2022 •
edited
Loading

@userpixel No worries, I know how hard it can be to find time. I'll make a fork, thanks for creating and sharing! Good luck with your new venture!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hooks

3 participants

@alexewerlof @tmikaeld
Morty Proxy This is a proxified and sanitized view of the page, visit original site.