Feature: allow to update CRN_LIST_URL from .env#232
Merged
Feature: allow to update CRN_LIST_URL from .env#232
Conversation
|
Summary: Highlight: - CRN_LIST_URL: ClassVar[str] = "https://crns-list.aleph.sh/crns.json"
+ CRN_LIST_URL: str = "https://crns-list.aleph.sh/crns.json"This change is unlikely to introduce bugs and is more about improving code clarity and maintainability. Therefore, it falls under the 'BLUE' category. |
aliel
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On CLI side we want to be able to run a fake crn_list api to be able to create instance / interact with a crn not listed in the crn_list.
The issue is having
CRN_LIST_URL as a ClassVar don't allow to update using .env