Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix programs for SOL payment chain#201

Merged
philogicae merged 1 commit intomainaleph-im/aleph-sdk-python:mainfrom
fix-sol-programaleph-im/aleph-sdk-python:fix-sol-programCopy head branch name to clipboard
Feb 24, 2025
Merged

Fix programs for SOL payment chain#201
philogicae merged 1 commit intomainaleph-im/aleph-sdk-python:mainfrom
fix-sol-programaleph-im/aleph-sdk-python:fix-sol-programCopy head branch name to clipboard

Conversation

@philogicae
Copy link
Member

No description provided.

@github-actions
Copy link

This PR introduces new parameters in several functions, including create_program in both abstract.py and authenticated_http.py. The new parameters are payment, vcpus, memory, and timeout_seconds. These changes could potentially introduce bugs or require a deep understanding of the project architecture, especially if the Payment class or the other parameters are used in complex ways. The addition of these parameters suggests a deeper level of involvement with the project's payment and resource management, which could affect the stability and security of the system. Therefore, this PR requires a thorough review to ensure that the changes do not introduce bugs or negatively impact the functionality of the system.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Feb 20, 2025
@philogicae philogicae self-assigned this Feb 20, 2025
@philogicae philogicae requested a review from nesitor February 20, 2025 12:16
@philogicae philogicae merged commit 7b86ff6 into main Feb 24, 2025
23 checks passed
@philogicae philogicae deleted the fix-sol-program branch February 24, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLACK This PR has critical implications and must be reviewed by a senior engineer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.