Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix the search by version#563

Merged
NolwennP merged 2 commits intomasterakeneo/pim-helpcenter:masterfrom
fix-search-by-versionakeneo/pim-helpcenter:fix-search-by-versionCopy head branch name to clipboard
May 25, 2020
Merged

Fix the search by version#563
NolwennP merged 2 commits intomasterakeneo/pim-helpcenter:masterfrom
fix-search-by-versionakeneo/pim-helpcenter:fix-search-by-versionCopy head branch name to clipboard

Conversation

@NolwennP
Copy link
Copy Markdown
Contributor

@NolwennP NolwennP commented Apr 27, 2020

There is a bug when you search over the Serenity version of the doc. It shows also the v3 version of the doc in Serenity.

That should fix it. What do you think @bgouraud?

@NolwennP NolwennP requested a review from bgouraud April 27, 2020 09:54
Copy link
Copy Markdown
Contributor

@bgouraud bgouraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also change line 8: <meta name="docsearch:solution" content="pimv3">

Copy link
Copy Markdown
Contributor

@bgouraud bgouraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@NolwennP NolwennP merged commit 8dfc4d0 into master May 25, 2020
@NolwennP NolwennP deleted the fix-search-by-version branch May 25, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.