Add test for Table-Driven-Vacuum-Agent.#747
Closed
roberthoenig wants to merge 1 commit intoaimacode:masteraimacode/aima-python:masterfrom
roberthoenig:add-tabledrivenvacuumagent-testroberthoenig/aima-python:add-tabledrivenvacuumagent-testCopy head branch name to clipboard
Closed
Add test for Table-Driven-Vacuum-Agent.#747roberthoenig wants to merge 1 commit intoaimacode:masteraimacode/aima-python:masterfrom roberthoenig:add-tabledrivenvacuumagent-testroberthoenig/aima-python:add-tabledrivenvacuumagent-testCopy head branch name to clipboard
roberthoenig wants to merge 1 commit intoaimacode:masteraimacode/aima-python:masterfrom
roberthoenig:add-tabledrivenvacuumagent-testroberthoenig/aima-python:add-tabledrivenvacuumagent-testCopy head branch name to clipboard
Conversation
Note that this changes the percept sequence table in the code, it now slightly differs from table 2.3 in the book. The underlying problem here is that a full table can principally not be specified, so '...' is used to represent the missing table entries. While this works for the book, the code requires some additional table entries for the agent to succeed.
Contributor
|
Hello, @roberthoenig! This issue has already been fixed in PR #732 and #738. Please see those PRs once. It would be better if we have a single PR for the same issue. |
Contributor
Author
Contributor
|
No problem, @roberthoenig! Thank you for your cooperation. Looking forward to your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this changes the percept sequence table in the code, it now slightly differs from table 2.3
in the book. The underlying problem here is that a full table can principally not be specified, so '...' is used to represent the missing table entries. While this works for the book, the code requires some additional table entries for the agent to succeed.
I can see how this approach might be considered less than optimal. If that's the case, I'm happy to discuss alternative solutions.