Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Resolved merge conflict#690

Closed
varunvora wants to merge 1 commit intoaimacode:masteraimacode/aima-python:masterfrom
varunvora:masterCopy head branch name to clipboard
Closed

Resolved merge conflict#690
varunvora wants to merge 1 commit intoaimacode:masteraimacode/aima-python:masterfrom
varunvora:masterCopy head branch name to clipboard

Conversation

@varunvora
Copy link

Fixed Issue #688

@antmarakis
Copy link
Collaborator

antmarakis commented Jan 13, 2018

Hello @varunvora, thanks for the help! Something went wrong with our automated testing software (Travis), can you close and re-open your PR to restart the testing?

Also the output of some notebook cells is "A Jupyter Widget". Why is that, did something go wrong?

Finally, in the future I suggest you follow the contributing guide, since your PR conflicts with #689. Opening an issue communicating what you are doing will help in coordinating the project. Hope this helps!

@varunvora varunvora closed this Jan 13, 2018
@varunvora
Copy link
Author

@MrDupin I believe @Dragneel7 's PR #689 fixes the issue
I don't know why the output of some cells were empty widgets. I will explicitly clear notebook widget state (if they are empty) until I find the fix for that.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.